Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(marker): fix marker label formatter can't get series information #19898

Merged
merged 1 commit into from
May 9, 2024

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented May 7, 2024

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix a long-term bug that marker label formatter can't get series information like seriesName, seriesType, and seriesId - This causes formatter template keywords like {a} not to work.

Fixed issues

Preview Online

https://echarts.apache.org/examples/editor.html?c=bar-rich-text&version=PR-19898

Comparison

Before Before
After After

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

Please refer to the second case in test/markPoint.html

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented May 7, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@plainheart plainheart added this to the 5.5.1 milestone May 7, 2024
Copy link
Contributor

github-actions bot commented May 7, 2024

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19898@f12a3c7

plainheart added a commit to apache/echarts-examples that referenced this pull request May 8, 2024
@Ovilia Ovilia merged commit 7e4c703 into master May 9, 2024
2 checks passed
Copy link

echarts-bot bot commented May 9, 2024

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart deleted the fix/marker/label-formatter-callback-params branch May 9, 2024 08:53
@nicobockko
Copy link

when could I see the fiexed chart?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Weather Statistics Example Dosen't work
3 participants