Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-33986][runtime] Extend ShuffleMaster to support snapshot and restore state. #24774

Merged
merged 1 commit into from
May 14, 2024

Conversation

JunRuiLee
Copy link
Contributor

What is the purpose of the change

Extend ShuffleMaster to support snapshot and restore state.

Brief change log

Extend shuffleMaster to support batch snapshot as follows:

  1. Add method supportsBatchSnapshot to identify whether the shuffle master supports taking snapshot in batch scenarios
  2. Add method snapshotState and restoreState to snapshot and restore the shuffle master's state.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented May 13, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@JunRuiLee
Copy link
Contributor Author

Thanks @zhuzhurk for review, I've updated this pr accordingly. PTAL~

Copy link
Contributor

@zhuzhurk zhuzhurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhuzhurk zhuzhurk merged commit 65d31e2 into apache:master May 14, 2024
@JunRuiLee JunRuiLee deleted the FLINK-33986 branch May 15, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants