Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-35193][table] Support drop materialized table syntax and execution in continuous refresh mode #24777

Merged
merged 4 commits into from
May 14, 2024
Merged

[FLINK-35193][table] Support drop materialized table syntax and execution in continuous refresh mode #24777

merged 4 commits into from
May 14, 2024

Conversation

hackergin
Copy link
Contributor

What is the purpose of the change

Support drop materialized table syntax and execution in continuous refresh mode

Brief change log

  • Support parser drop materialized table syntax in flink-sql-parser module
  • Add DropMaterializedTableConverter for convert drop materialized table node to operations
  • Support execution of drop materialized table

Verifying this change

  • Added integration test for create and drop materialized table
  • Add drop table operation in MaterializedTableStatementITCase after every test case finished

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (will be added in a separated pr)

@lsyldliu lsyldliu changed the title [FLINK-5193][table] Support drop materialized table syntax and execution in continuous refresh mode [FLINK-35193][table] Support drop materialized table syntax and execution in continuous refresh mode May 13, 2024
@flinkbot
Copy link
Collaborator

flinkbot commented May 13, 2024 •
edited

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@hackergin hackergin force-pushed the FLINK-35193 branch 2 times, most recently from 70d5b7c to fbec70e Compare May 13, 2024 12:53
lsyldliu
lsyldliu reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@lsyldliu lsyldliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hackergin Thanks for your contribution, I left some comments.

...flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlDropMaterializedTable.java Outdated Show resolved Hide resolved
flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl Outdated Show resolved Hide resolved
flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl Outdated Show resolved Hide resolved
...l-parser/src/test/java/org/apache/flink/sql/parser/MaterializedTableStatementParserTest.java Show resolved Hide resolved
.../org/apache/flink/table/planner/operations/converters/SqlDropMaterializedTableConverter.java Show resolved Hide resolved
.../java/org/apache/flink/table/gateway/service/materializedtable/MaterializedTableManager.java Outdated Show resolved Hide resolved
...y/src/test/java/org/apache/flink/table/gateway/service/MaterializedTableStatementITCase.java Show resolved Hide resolved
...y/src/test/java/org/apache/flink/table/gateway/service/MaterializedTableStatementITCase.java Show resolved Hide resolved
.../java/org/apache/flink/table/gateway/service/materializedtable/MaterializedTableManager.java Show resolved Hide resolved
...y/src/test/java/org/apache/flink/table/gateway/service/MaterializedTableStatementITCase.java Show resolved Hide resolved
lsyldliu
lsyldliu reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@lsyldliu lsyldliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, left two comments.

.../java/org/apache/flink/table/gateway/service/materializedtable/MaterializedTableManager.java Outdated Show resolved Hide resolved
.../java/org/apache/flink/table/gateway/service/materializedtable/MaterializedTableManager.java Outdated Show resolved Hide resolved
...ateway/src/main/java/org/apache/flink/table/gateway/service/operation/OperationExecutor.java Outdated Show resolved Hide resolved
@hackergin hackergin force-pushed the FLINK-35193 branch 2 times, most recently from 6ecf9fb to a2ffd6f Compare May 14, 2024 09:18
lsyldliu
lsyldliu approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@lsyldliu lsyldliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsyldliu lsyldliu merged commit 94d861b into apache:master May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsyldliu lsyldliu lsyldliu approved these changes

Assignees
No one assigned
Labels
component=TableSQL/API
Projects
None yet
Milestone
No milestone
3 participants
@hackergin @flinkbot @lsyldliu