Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-33983][runtime] Introduce JobEvent and JobEventStore #24782

Merged
merged 1 commit into from
May 19, 2024
Merged

[FLINK-33983][runtime] Introduce JobEvent and JobEventStore #24782

merged 1 commit into from
May 19, 2024

Conversation

JunRuiLee
Copy link
Contributor

What is the purpose of the change

[FLINK-33983][runtime] Introduce JobEvent and JobEventStore

Brief change log

Introduce JobEvent and JobEventStore

Verifying this change

This change added tests and can be verified as follows:

  • ExecutionJobVertexInitializedEventTest
  • ExecutionVertexFinishedEventTest
  • ExecutionVertexResetEventTest
  • FileSystemJobEventStoreTest
  • FsBatchFlushOutputStreamTest
  • JobEventManagerTest
  • TestingJobEvent

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented May 14, 2024 •
edited

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

zhuzhurk
zhuzhurk reviewed May 16, 2024
View reviewed changes
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/event/DummyJobEventStore.java Outdated Show resolved Hide resolved
...c/main/java/org/apache/flink/runtime/jobmaster/event/ExecutionJobVertexInitializedEvent.java Outdated Show resolved Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/event/JobEvent.java Outdated Show resolved Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/event/JobEvent.java Outdated Show resolved Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/event/JobEventManager.java Outdated Show resolved Hide resolved
...-runtime/src/main/java/org/apache/flink/runtime/jobmaster/event/FileSystemJobEventStore.java Outdated Show resolved Hide resolved
...-runtime/src/main/java/org/apache/flink/runtime/jobmaster/event/FileSystemJobEventStore.java Outdated Show resolved Hide resolved
...-runtime/src/main/java/org/apache/flink/runtime/jobmaster/event/FileSystemJobEventStore.java Show resolved Hide resolved
...ime/src/main/java/org/apache/flink/runtime/jobmaster/event/ExecutionVertexFinishedEvent.java Outdated Show resolved Hide resolved
...ime/src/main/java/org/apache/flink/runtime/jobmaster/event/ExecutionVertexFinishedEvent.java Outdated Show resolved Hide resolved
@JunRuiLee
Copy link
Contributor Author

Thanks @zhuzhurk for review, I've updated this pr accordingly. PTAL.

zhuzhurk
zhuzhurk reviewed May 17, 2024
View reviewed changes
Copy link
Contributor

@zhuzhurk zhuzhurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all the comments! @JunRuiLee
I have last two minor comments.

...runtime/src/main/java/org/apache/flink/runtime/jobmaster/event/FsBatchFlushOutputStream.java Outdated Show resolved Hide resolved
...time/src/test/java/org/apache/flink/runtime/jobmaster/event/FileSystemJobEventStoreTest.java Outdated Show resolved Hide resolved
zhuzhurk
zhuzhurk approved these changes May 19, 2024
View reviewed changes
Copy link
Contributor

@zhuzhurk zhuzhurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhuzhurk zhuzhurk merged commit c7c1d78 into apache:master May 19, 2024
@JunRuiLee JunRuiLee deleted the F-33983 branch May 19, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhuzhurk zhuzhurk zhuzhurk approved these changes

Assignees
No one assigned
Labels
component=Runtime/Coordination
Projects
None yet
Milestone
No milestone
3 participants
@JunRuiLee @flinkbot @zhuzhurk