GROOVY-10378: coerce iterable to array or collection

3_0_X backport
apache · May 16, 2024 · db34345 · db34345
1 parent 653627c
commit db34345
Show file tree

Hide file tree

Showing 2 changed files with 93 additions and 22 deletions.
diff --git a/src/main/java/org/codehaus/groovy/runtime/typehandling/DefaultTypeTransformation.java b/src/main/java/org/codehaus/groovy/runtime/typehandling/DefaultTypeTransformation.java
@@ -23,14 +23,7 @@
 import groovy.lang.GroovyRuntimeException;
 import org.codehaus.groovy.reflection.ReflectionCache;
 import org.codehaus.groovy.reflection.stdclasses.CachedSAMClass;
-import org.codehaus.groovy.runtime.DefaultGroovyMethods;
-import org.codehaus.groovy.runtime.InvokerHelper;
-import org.codehaus.groovy.runtime.InvokerInvocationException;
-import org.codehaus.groovy.runtime.IteratorClosureAdapter;
-import org.codehaus.groovy.runtime.MethodClosure;
-import org.codehaus.groovy.runtime.NullObject;
-import org.codehaus.groovy.runtime.ResourceGroovyMethods;
-import org.codehaus.groovy.runtime.StringGroovyMethods;
+import org.codehaus.groovy.runtime.*;
 
 import java.io.File;
 import java.io.IOException;
@@ -49,6 +42,7 @@
 import java.util.List;
 import java.util.Map;
 import java.util.Objects;
+import java.util.function.Supplier;
 
 /**
  * Class providing various type conversions, coercions and boxing/unboxing operations.
@@ -248,20 +242,22 @@ private static Object continueCastOnCollection(Object object, Class type) {
             return new LinkedHashSet((Collection) object);
         }
 
-        if (object.getClass().isArray()) {
-            Collection answer;
+        Supplier<Collection> newCollection = () -> {
             if (type.isAssignableFrom(ArrayList.class) && Modifier.isAbstract(type.getModifiers())) {
-                answer = new ArrayList();
+                return new ArrayList();
             } else if (type.isAssignableFrom(LinkedHashSet.class) && Modifier.isAbstract(type.getModifiers())) {
-                answer = new LinkedHashSet();
+                return new LinkedHashSet();
             } else {
                 try {
-                    answer = (Collection) type.getDeclaredConstructor().newInstance();
+                    return (Collection) type.getDeclaredConstructor().newInstance();
                 } catch (Exception e) {
                     throw new GroovyCastException("Could not instantiate instance of: " + type.getName() + ". Reason: " + e);
                 }
             }
+        };
 
+        if (object.getClass().isArray()) {
+            Collection answer = newCollection.get();
             // we cannot just wrap in a List as we support primitive type arrays
             int length = Array.getLength(object);
             for (int i = 0; i < length; i += 1) {
@@ -270,6 +266,14 @@ private static Object continueCastOnCollection(Object object, Class type) {
             return answer;
         }
 
+        if (object instanceof Iterable // GROOVY-11378
+              && !(object instanceof Collection)) { // GROOVY-7867
+            Collection answer = newCollection.get();
+            Iterator iterator = ((Iterable) object).iterator();
+            while (iterator.hasNext()) answer.add(iterator.next());
+            return answer;
+        }
+
         return continueCastOnNumber(object, type);
     }
 
@@ -442,22 +446,24 @@ public static Collection asCollection(Object value) {
             return map.entrySet();
         } else if (value.getClass().isArray()) {
             return arrayAsCollection(value);
-        } else if (value instanceof MethodClosure) {
-            MethodClosure method = (MethodClosure) value;
-            IteratorClosureAdapter adapter = new IteratorClosureAdapter(method.getDelegate());
-            method.call(adapter);
-            return adapter.asList();
         } else if (value instanceof String || value instanceof GString) {
             return StringGroovyMethods.toList((CharSequence) value);
+        } else if (value instanceof Iterable) { // GROOVY-10378
+            return DefaultGroovyMethods.toList((Iterable<?>) value);
+        } else if (value instanceof Class && ((Class) value).isEnum()) {
+            Object[] values = (Object[]) InvokerHelper.invokeMethod(value, "values", EMPTY_OBJECT_ARRAY);
+            return Arrays.asList(values);
         } else if (value instanceof File) {
             try {
                 return ResourceGroovyMethods.readLines((File) value);
             } catch (IOException e) {
                 throw new GroovyRuntimeException("Error reading file: " + value, e);
             }
-        } else if (value instanceof Class && ((Class) value).isEnum()) {
-            Object[] values = (Object[]) InvokerHelper.invokeMethod(value, "values", EMPTY_OBJECT_ARRAY);
-            return Arrays.asList(values);
+        } else if (value instanceof MethodClosure) {
+            MethodClosure method = (MethodClosure) value;
+            IteratorClosureAdapter<?> adapter = new IteratorClosureAdapter<>(method.getDelegate());
+            method.call(adapter);
+            return adapter.asList();
         } else {
             // let's assume it's a collection of 1
             return Collections.singletonList(value);

diff --git a/src/test/org/codehaus/groovy/runtime/typehandling/DefaultTypeTransformationTest.groovy b/src/test/org/codehaus/groovy/runtime/typehandling/DefaultTypeTransformationTest.groovy
@@ -25,7 +25,7 @@ import static groovy.test.GroovyAssert.shouldFail
 final class DefaultTypeTransformationTest {
 
     @Test
-    void testCastToType() {
+    void testCastToType1() {
         def input = null, result
 
         result = DefaultTypeTransformation.castToType(input, int)
@@ -53,6 +53,71 @@ final class DefaultTypeTransformationTest {
         assert result === input
     }
 
+    @Test
+    void testCastToType2() {
+        def input = new int[] {0,1}, result
+
+        result = DefaultTypeTransformation.castToType(input, Number[])
+        assert result instanceof Number[]
+        assert result[0] == 0
+        assert result[1] == 1
+
+        result = DefaultTypeTransformation.castToType(input, List)
+        assert result instanceof List
+        assert result[0] == 0
+        assert result[1] == 1
+
+        result = DefaultTypeTransformation.castToType(input, Set)
+        assert result instanceof Set
+        assert result[0] == 0
+        assert result[1] == 1
+    }
+
+    @Test
+    void testCastToType3() {
+        def input = Arrays.asList(0,1), result
+
+        result = DefaultTypeTransformation.castToType(input, Number[])
+        assert result instanceof Number[]
+        assert result[0] == 0
+        assert result[1] == 1
+
+        result = DefaultTypeTransformation.castToType(input, List)
+        assert result === input
+        assert result[0] == 0
+        assert result[1] == 1
+
+        result = DefaultTypeTransformation.castToType(input, Set)
+        assert result instanceof Set
+        assert result[0] == 0
+        assert result[1] == 1
+    }
+
+    @Test // GROOVY-11378
+    void testCastToType4() {
+        def input = new org.codehaus.groovy.util.ArrayIterable<Integer>(0,1), result
+
+        result = DefaultTypeTransformation.castToType(input, Number[])
+        assert result instanceof Number[]
+        assert result[0] == 0
+        assert result[1] == 1
+
+        result = DefaultTypeTransformation.castToType(input, int[])
+        assert result instanceof int[]
+        assert result[0] == 0
+        assert result[1] == 1
+
+        result = DefaultTypeTransformation.castToType(input, List)
+        assert result instanceof List
+        assert result[0] == 0
+        assert result[1] == 1
+
+        result = DefaultTypeTransformation.castToType(input, Set)
+        assert result instanceof Set
+        assert result[0] == 0
+        assert result[1] == 1
+    }
+
     @Test
     void testCompareTo() {
         // objects