HADOOP-18508. S3A: Support parallel integration test runs on same bucket #5081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
s3 london where mvit is mvn verify with some options need to run a few more times to make sure all files are created in isolation. then kick off two test runs in different source trees at the same time |
|
💔 -1 overall
This message was automatically generated. |
steveloughran
force-pushed
the
s3/HADOOP-18508-parallel-test-jobs
branch
from
409f306
to
d43c91d
Compare
|
rebased; running as an experiment. the jobid stuff is all set up in the pom.xml. i actually want to be able to set it in the auth-keys.xml file, as that would let me set up different source trees testing against different parts of the same store. proposed: support it as a sysprop or a config option |
steveloughran
force-pushed
the
s3/HADOOP-18508-parallel-test-jobs
branch
from
d43c91d
to
c4ec4ad
Compare
steveloughran
force-pushed
the
s3/HADOOP-18508-parallel-test-jobs
branch
from
c4ec4ad
to
a37254e
Compare
steveloughran
force-pushed
the
s3/HADOOP-18508-parallel-test-jobs
branch
from
a37254e
to
e142a67
Compare
steveloughran
force-pushed
the
s3/HADOOP-18508-parallel-test-jobs
branch
from
e142a67
to
29386a6
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
Can I chase @mukund-thakur @HarshitGupta11 @ahmarsuhail for reviews here. This is so we can run multiple CI tests against the same bucket in parallel. |
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/testing.md
Outdated
Show resolved
Hide resolved
| @Test | ||
| @Override | ||
| public void testWDAbsolute() throws IOException { | ||
| Path absoluteDir = getTestRootPath(fSys, "test/existingDir"); |
There was a problem hiding this comment.
could you please explain this test a bit more.
There was a problem hiding this comment.
override of the superclass. just needed a test relative path.
I've cut this and fixed the base class; other subclasses copy this fix and it is harmless on others
| * @throws IOException failure | ||
| */ | ||
| @Override | ||
| protected void deleteTestDirInTeardown() throws IOException { |
There was a problem hiding this comment.
So for the huge files test, we will have to delete manually via the S3 lifecycle rule as mentioned in the testting.doc?
This is just to reduce the time taken by tests right?
There was a problem hiding this comment.
we delete the dir in test_800_DeleteHugeFiles(), at the end of the entire sequence of operations
There was a problem hiding this comment.
that is only for the huge file. the testPath still remains right?
|
Are you running multiple parallel tests in different terminal windows to verify everything is correct? |
|
🎊 +1 overall
This message was automatically generated. |
|
ooh, good point. I did a while back, but let me kick that off again |
|
...and I've found out that terasort paths aren't isolated |
|
🎊 +1 overall
This message was automatically generated. |
|
checkstyles where I changed the base contract tests |
|
🎊 +1 overall
This message was automatically generated. |
steveloughran
changed the title
|
+what were the mvn commands used? |
above error on even a single test run as well. Not related to parallelism.
I just figured out while debugging that we should be on different copies of hadoop source tree. So I think we should mention this in doc. |
|
I have SSE-KMS with key configured in auth-keys.xml |
|
Re-ran parallelly in two terminals and I think we are good apart from the above failure. and the above test passes in my trunk branch. |
|
These two tests are failing on trunk as well.
|
|
I need to sit down and fix that committer factory one. nothing hard but it is irritating me |
|
..it and the STS one are both with jiras. STS failure depends on the region you are running from, so it is test setup. |
|
@mukund-thakur given the failures you saw were just related to you not reading the docs, can we merge this? |
|
mukund-thakur
approved these changes
May 23, 2024
|
let me rebase and look at the failing test before I merge. You are only seeing it on this branch? Draft message for the commit |
…et in parallel * adds job id to fork id * adds option to disable root tests * documents this * gets more tests working under the job/fork subdir rather than absolute paths. tracking them down is tricky. Change-Id: I95530f883307b66971c0300631993798967b6739
Change-Id: Ieb9b5bbb0644c9e030dbdc80f51a032964e727ab
Change-Id: If00e579a831110886e0e1ade46fe72dbe70269fa
* cut mention of cloudstore sessionkeys * review changes and cut back on diff Change-Id: Ib2bdd02921f7cdbf9e0b924cab0bfbf30f21c395
Change-Id: I48fc6b30ba69a616fae688c45dffacc5da504014
* terasort uses path under fork/job id, which requires disabling test dir cleanup. * +method name for logs includes memory option * +reports CSV file includes memory flag * sequential and surefire test runs also pass down job id, so that it is possible to safely run a single test in one process while a full suite runs against the same bucket. Change-Id: Ib37ef6b5f23e5e7beb53d7c04c44e811ac4e2fa3
Change-Id: Ia2aa6e793a02914f2e391ad699ab998975f1a982
…ileSystem I thought I'd already cleaned them, but yetus was still unhappy. cleaned up the test even more to see if that helps Change-Id: If4096e70e7921db8790fb56351077840cb4317d9
steveloughran
force-pushed
the
s3/HADOOP-18508-parallel-test-jobs
branch
from
23e696c
to
d82fa09
Compare
-always create base dir at the start of each test -use methodPath() -remove final relics of s3guard comments/qualifiers -remove parameterization on directory marker retention, the default of "keep" stresses the trickiest bit of the code as it leaves more markers around. Change-Id: Ib1fa2940116170bd5d00375ab51ed582f8cad1f6
|
@mukund-thakur couldn't replicate the failure but I'd disabled the tests during some s3express testing and not-reenabled it. still couldn't replicate it. and when you skip root tests then it's also disabled as mixing SSE-C really causes problems. Or at least used to. Anyway, I've made sure the suite sets a base dir at the start of each methodPath() and builds each sub path off it, whatever problem you encountered seems to have been related. I also cut out the markers=delete run phase as its markers=keep where more problems surface...this saves 30s off the test suite. Which makes me think: we should review when we use markers=delete and other than for some compatibility tests, remove them all. What do you think about having more time in your life back? |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
4 tasks
|
Failing test ITestS3AEncryptionSSEC succeeded after your change. So good to merge pending yetus. +1 And I would for sure want some more time in my life back. |
Change-Id: I18a0bd833f302cbcc4676987647a6ce3ec731a8e
surely you mean "some more time to work on JIRAs" |
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How was this patch tested?
running the forked tests with different job ids, disabling root dir cleanup and seeing what was created in separate subdirs
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?