Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YARN-11471. [Federation] FederationStateStoreFacade Cache Support Caffeine. #6795

Merged
merged 6 commits into from
May 31, 2024

Conversation

slfan1989
Copy link
Contributor

@slfan1989 slfan1989 commented May 4, 2024

Description of PR

JIRA: YARN-11471. FederationStateStoreFacade Cache Support Caffeine.

In YARN Federation, we already support two types of cache:

  • Guava Cache
  • Ehcache.

Currently, another popular Java cache is CaffeineCache, which has better execution performance and is more actively updated. It is a cache supported by the Apache license.

Project homepage:
https://github.com/ben-manes/caffeine

We can learn about the performance of this cache from the following documentation:

  1. Caffeine Cache: A High Performance Caching Library
  2. Cache2k Java Caching Benchmarks

How was this patch tested?

Using historical frameworks for unit testing.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@slfan1989 slfan1989 changed the title YARN-11471. FederationStateStoreFacade Cache Support Caffeine. YARN-11471. [Federation] FederationStateStoreFacade Cache Support Caffeine. May 4, 2024
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
_ Prechecks _
+1 💚 dupname 0m 01s No case conflicting files found.
+0 🆗 codespell 0m 01s codespell was not available.
+0 🆗 detsecrets 0m 01s detect-secrets was not available.
+0 🆗 shellcheck 0m 01s Shellcheck was not available.
+0 🆗 shelldocs 0m 01s Shelldocs was not available.
+0 🆗 xmllint 0m 01s xmllint was not available.
+0 🆗 spotbugs 0m 01s spotbugs executables are not available.
+0 🆗 markdownlint 0m 01s markdownlint was not available.
+1 💚 @author 0m 00s The patch does not contain any @author tags.
+1 💚 test4tests 0m 00s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 2m 13s Maven dependency ordering for branch
+1 💚 mvninstall 86m 03s trunk passed
+1 💚 compile 37m 48s trunk passed
+1 💚 checkstyle 5m 42s trunk passed
-1 ❌ mvnsite 22m 54s /branch-mvnsite-root.txt root in trunk failed.
+1 💚 javadoc 15m 36s trunk passed
+1 💚 shadedclient 184m 46s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 2m 20s Maven dependency ordering for patch
-1 ❌ mvninstall 81m 39s /patch-mvninstall-root.txt root in the patch failed.
+1 💚 compile 38m 56s the patch passed
+1 💚 javac 38m 56s the patch passed
+1 💚 blanks 0m 01s The patch has no blanks issues.
+1 💚 checkstyle 7m 00s the patch passed
-1 ❌ mvnsite 22m 18s /patch-mvnsite-root.txt root in the patch failed.
+1 💚 javadoc 14m 54s the patch passed
-1 ❌ shadedclient 193m 21s patch has errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 6m 10s The patch does not generate ASF License warnings.
646m 42s
Subsystem Report/Notes
GITHUB PR #6795
Optional Tests dupname asflicense codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall mvnsite unit shadedclient xmllint spotbugs checkstyle markdownlint
uname MINGW64_NT-10.0-17763 efe4716c0f2c 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys
Build tool maven
Personality /c/hadoop/dev-support/bin/hadoop.sh
git revision trunk / 46c6ca5
Default Java Azul Systems, Inc.-1.8.0_332-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6795/1/testReport/
modules C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6795/1/console
versions git=2.44.0.windows.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
_ Prechecks _
+1 💚 dupname 0m 02s No case conflicting files found.
+0 🆗 codespell 0m 02s codespell was not available.
+0 🆗 detsecrets 0m 02s detect-secrets was not available.
+0 🆗 shellcheck 0m 02s Shellcheck was not available.
+0 🆗 shelldocs 0m 02s Shelldocs was not available.
+0 🆗 xmllint 0m 00s xmllint was not available.
+0 🆗 spotbugs 0m 00s spotbugs executables are not available.
+0 🆗 markdownlint 0m 00s markdownlint was not available.
+1 💚 @author 0m 00s The patch does not contain any @author tags.
+1 💚 test4tests 0m 00s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 2m 13s Maven dependency ordering for branch
+1 💚 mvninstall 86m 09s trunk passed
+1 💚 compile 38m 04s trunk passed
+1 💚 checkstyle 5m 44s trunk passed
-1 ❌ mvnsite 22m 33s /branch-mvnsite-root.txt root in trunk failed.
+1 💚 javadoc 15m 57s trunk passed
+1 💚 shadedclient 187m 42s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 2m 25s Maven dependency ordering for patch
-1 ❌ mvninstall 83m 37s /patch-mvninstall-root.txt root in the patch failed.
+1 💚 compile 38m 06s the patch passed
+1 💚 javac 38m 06s the patch passed
+1 💚 blanks 0m 00s The patch has no blanks issues.
+1 💚 checkstyle 5m 48s the patch passed
-1 ❌ mvnsite 23m 12s /patch-mvnsite-root.txt root in the patch failed.
+1 💚 javadoc 16m 13s the patch passed
-1 ❌ shadedclient 196m 14s patch has errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 6m 11s The patch does not generate ASF License warnings.
654m 42s
Subsystem Report/Notes
GITHUB PR #6795
Optional Tests dupname asflicense codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall mvnsite unit shadedclient xmllint spotbugs checkstyle markdownlint
uname MINGW64_NT-10.0-17763 ed55179f37c5 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys
Build tool maven
Personality /c/hadoop/dev-support/bin/hadoop.sh
git revision trunk / 46c6ca5
Default Java Azul Systems, Inc.-1.8.0_332-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6795/2/testReport/
modules C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6795/2/console
versions git=2.44.0.windows.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
_ Prechecks _
+1 💚 dupname 0m 01s No case conflicting files found.
+0 🆗 codespell 0m 02s codespell was not available.
+0 🆗 detsecrets 0m 02s detect-secrets was not available.
+0 🆗 shellcheck 0m 02s Shellcheck was not available.
+0 🆗 shelldocs 0m 02s Shelldocs was not available.
+0 🆗 xmllint 0m 00s xmllint was not available.
+0 🆗 spotbugs 0m 00s spotbugs executables are not available.
+0 🆗 markdownlint 0m 00s markdownlint was not available.
+1 💚 @author 0m 01s The patch does not contain any @author tags.
+1 💚 test4tests 0m 00s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 2m 21s Maven dependency ordering for branch
+1 💚 mvninstall 94m 17s trunk passed
+1 💚 compile 42m 36s trunk passed
+1 💚 checkstyle 6m 22s trunk passed
-1 ❌ mvnsite 25m 38s /branch-mvnsite-root.txt root in trunk failed.
+1 💚 javadoc 18m 48s trunk passed
+1 💚 shadedclient 210m 12s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 2m 38s Maven dependency ordering for patch
+1 💚 mvninstall 99m 57s the patch passed
+1 💚 compile 43m 37s the patch passed
+1 💚 javac 43m 37s the patch passed
+1 💚 blanks 0m 00s The patch has no blanks issues.
+1 💚 checkstyle 7m 33s the patch passed
-1 ❌ mvnsite 24m 57s /patch-mvnsite-root.txt root in the patch failed.
+1 💚 javadoc 17m 06s the patch passed
+1 💚 shadedclient 217m 51s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 7m 45s The patch does not generate ASF License warnings.
727m 24s
Subsystem Report/Notes
GITHUB PR #6795
Optional Tests dupname asflicense codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall mvnsite unit shadedclient xmllint spotbugs checkstyle markdownlint
uname MINGW64_NT-10.0-17763 7d8350823e1a 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys
Build tool maven
Personality /c/hadoop/dev-support/bin/hadoop.sh
git revision trunk / ac7dbd1
Default Java Azul Systems, Inc.-1.8.0_332-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6795/3/testReport/
modules C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6795/3/console
versions git=2.45.0.windows.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
_ Prechecks _
+1 💚 dupname 0m 01s No case conflicting files found.
+0 🆗 codespell 0m 01s codespell was not available.
+0 🆗 detsecrets 0m 01s detect-secrets was not available.
+0 🆗 shellcheck 0m 02s Shellcheck was not available.
+0 🆗 shelldocs 0m 02s Shelldocs was not available.
+0 🆗 xmllint 0m 00s xmllint was not available.
+0 🆗 spotbugs 0m 00s spotbugs executables are not available.
+0 🆗 markdownlint 0m 00s markdownlint was not available.
+1 💚 @author 0m 00s The patch does not contain any @author tags.
+1 💚 test4tests 0m 01s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 2m 16s Maven dependency ordering for branch
+1 💚 mvninstall 90m 30s trunk passed
+1 💚 compile 40m 45s trunk passed
+1 💚 checkstyle 6m 00s trunk passed
-1 ❌ mvnsite 23m 14s /branch-mvnsite-root.txt root in trunk failed.
+1 💚 javadoc 18m 33s trunk passed
+1 💚 shadedclient 198m 44s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 2m 26s Maven dependency ordering for patch
+1 💚 mvninstall 98m 44s the patch passed
+1 💚 compile 40m 42s the patch passed
+1 💚 javac 40m 42s the patch passed
+1 💚 blanks 0m 00s The patch has no blanks issues.
+1 💚 checkstyle 6m 04s the patch passed
-1 ❌ mvnsite 24m 17s /patch-mvnsite-root.txt root in the patch failed.
+1 💚 javadoc 17m 08s the patch passed
+1 💚 shadedclient 210m 44s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 6m 30s The patch does not generate ASF License warnings.
697m 52s
Subsystem Report/Notes
GITHUB PR #6795
Optional Tests dupname asflicense codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall mvnsite unit shadedclient xmllint spotbugs checkstyle markdownlint
uname MINGW64_NT-10.0-17763 6f5c5539c887 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys
Build tool maven
Personality /c/hadoop/dev-support/bin/hadoop.sh
git revision trunk / 8c86187
Default Java Azul Systems, Inc.-1.8.0_332-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6795/4/testReport/
modules C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase/hadoop-yarn-server-timelineservice-hbase-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6795/4/console
versions git=2.44.0.windows.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@@ -536,7 +536,7 @@ To enable cross-origin support (CORS) for the Yarn Router, please set the follow
#### How to configure Router Cache

Cache is enabled by default. When we set the `yarn.federation.cache-ttl.secs` parameter and its value is greater than 0, Cache will be enabled.
We currently provide two Cache implementations: `JCache` and `GuavaCache`.
We currently provide Three Cache implementations: `JCache` , `GuavaCache`, `CaffeineCache`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

three with lower case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your suggestions! I will improve the documentation.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ patch 0m 19s #6795 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.
Subsystem Report/Notes
GITHUB PR #6795
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6795/6/console
versions git=2.34.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ patch 0m 21s #6795 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.
Subsystem Report/Notes
GITHUB PR #6795
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6795/7/console
versions git=2.34.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
-1 ❌ patch 0m 44s #6795 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.
Subsystem Report/Notes
GITHUB PR #6795
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6795/7/console
versions git=2.45.0.windows.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
_ Prechecks _
+1 💚 dupname 0m 01s No case conflicting files found.
+0 🆗 codespell 0m 01s codespell was not available.
+0 🆗 detsecrets 0m 01s detect-secrets was not available.
+0 🆗 shellcheck 0m 01s Shellcheck was not available.
+0 🆗 shelldocs 0m 01s Shelldocs was not available.
+0 🆗 xmllint 0m 01s xmllint was not available.
+0 🆗 spotbugs 0m 01s spotbugs executables are not available.
+0 🆗 markdownlint 0m 01s markdownlint was not available.
+1 💚 @author 0m 00s The patch does not contain any @author tags.
+1 💚 test4tests 0m 00s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 5m 00s Maven dependency ordering for branch
+1 💚 mvninstall 89m 08s trunk passed
+1 💚 compile 40m 19s trunk passed
+1 💚 checkstyle 5m 57s trunk passed
-1 ❌ mvnsite 22m 54s /branch-mvnsite-root.txt root in trunk failed.
+1 💚 javadoc 16m 09s trunk passed
+1 💚 shadedclient 196m 27s branch has no errors when building and testing our client artifacts.
-0 ⚠️ patch 198m 55s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗 mvndep 2m 32s Maven dependency ordering for patch
+1 💚 mvninstall 98m 13s the patch passed
+1 💚 compile 39m 14s the patch passed
+1 💚 javac 39m 14s the patch passed
+1 💚 blanks 0m 01s The patch has no blanks issues.
+1 💚 checkstyle 5m 56s the patch passed
-1 ❌ mvnsite 24m 03s /patch-mvnsite-root.txt root in the patch failed.
+1 💚 javadoc 16m 39s the patch passed
+1 💚 shadedclient 207m 32s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 6m 18s The patch does not generate ASF License warnings.
691m 15s
Subsystem Report/Notes
GITHUB PR #6795
Optional Tests dupname asflicense codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall mvnsite unit shadedclient xmllint spotbugs checkstyle markdownlint
uname MINGW64_NT-10.0-17763 a46a48cd5fda 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys
Build tool maven
Personality /c/hadoop/dev-support/bin/hadoop.sh
git revision trunk / 7bb4dc1
Default Java Azul Systems, Inc.-1.8.0_332-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6795/8/testReport/
modules C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase/hadoop-yarn-server-timelineservice-hbase-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6795/8/console
versions git=2.45.0.windows.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@slfan1989
Copy link
Contributor Author

@goiri Can you help review this pr again? Thank you very much! The error reported by mvn compilation is not caused by our changes.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
_ Prechecks _
+1 💚 dupname 0m 02s No case conflicting files found.
+0 🆗 codespell 0m 02s codespell was not available.
+0 🆗 detsecrets 0m 02s detect-secrets was not available.
+0 🆗 shellcheck 0m 02s Shellcheck was not available.
+0 🆗 shelldocs 0m 02s Shelldocs was not available.
+0 🆗 xmllint 0m 01s xmllint was not available.
+0 🆗 spotbugs 0m 01s spotbugs executables are not available.
+0 🆗 markdownlint 0m 01s markdownlint was not available.
+1 💚 @author 0m 00s The patch does not contain any @author tags.
+1 💚 test4tests 0m 00s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 4m 20s Maven dependency ordering for branch
+1 💚 mvninstall 117m 00s trunk passed
+1 💚 compile 52m 52s trunk passed
+1 💚 checkstyle 7m 51s trunk passed
-1 ❌ mvnsite 33m 39s /branch-mvnsite-root.txt root in trunk failed.
+1 💚 javadoc 20m 56s trunk passed
+1 💚 shadedclient 250m 07s branch has no errors when building and testing our client artifacts.
-0 ⚠️ patch 253m 56s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗 mvndep 3m 05s Maven dependency ordering for patch
+1 💚 mvninstall 123m 48s the patch passed
+1 💚 compile 52m 55s the patch passed
+1 💚 javac 52m 55s the patch passed
+1 💚 blanks 0m 01s The patch has no blanks issues.
+1 💚 checkstyle 8m 23s the patch passed
-1 ❌ mvnsite 31m 50s /patch-mvnsite-root.txt root in the patch failed.
+1 💚 javadoc 21m 06s the patch passed
+1 💚 shadedclient 266m 42s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 9m 50s The patch does not generate ASF License warnings.
890m 05s
Subsystem Report/Notes
GITHUB PR #6795
Optional Tests dupname asflicense codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall mvnsite unit shadedclient xmllint spotbugs checkstyle markdownlint
uname MINGW64_NT-10.0-17763 1b8708b85dfd 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys
Build tool maven
Personality /c/hadoop/dev-support/bin/hadoop.sh
git revision trunk / e1e3e74
Default Java Azul Systems, Inc.-1.8.0_332-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6795/9/testReport/
modules C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase/hadoop-yarn-server-timelineservice-hbase-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6795/9/console
versions git=2.44.0.windows.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@slfan1989 slfan1989 merged commit 9f6c997 into apache:trunk May 31, 2024
1 of 2 checks passed
@slfan1989
Copy link
Contributor Author

@goiri Thank you very much for reviewing the code! I merged this pr into the trunk branch. The related compilation error has nothing to do with our code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants