[feature]Support grafana charts for Prometheus #1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomsun28
added
enhancement
wang1027-wqh
previously approved these changes
Mar 22, 2024
Signed-off-by: Logic <zqr10159@dromara.org>
…afana # Conflicts: # web-app/src/app/routes/monitor/monitor.module.ts
|
@tomsun28 I resolved conflicts and test errors ，please help review them. |
wang1027-wqh
previously approved these changes
Apr 14, 2024
grafana/src/main/java/org/dromara/hertzbeat/grafana/config/GrafanaInit.java
Outdated
Show resolved
Hide resolved
grafana/src/main/java/org/dromara/hertzbeat/grafana/config/GrafanaInit.java
Outdated
Show resolved
Hide resolved
…afana # Conflicts: # common/src/main/java/org/apache/hertzbeat/common/entity/manager/Monitor.java # web-app/src/app/pojo/Monitor.ts # web-app/src/app/routes/monitor/monitor.module.ts
…eature#grafana # Conflicts: # common/src/main/java/org/apache/hertzbeat/common/entity/manager/Monitor.java
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has checked 2042 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 871 | 5 | 1166 | 0 |
Click to see the invalid file list
- common/src/main/java/org/apache/hertzbeat/common/entity/grafana/Dashboard.java
- common/src/main/java/org/apache/hertzbeat/common/entity/grafana/Grafana.java
- common/src/main/java/org/apache/hertzbeat/common/entity/grafana/ServiceAccount.java
- common/src/main/java/org/apache/hertzbeat/common/entity/grafana/ServiceToken.java
- web-app/src/app/pojo/Grafana.ts
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
common/src/main/java/org/apache/hertzbeat/common/entity/grafana/Dashboard.java
Show resolved
Hide resolved
common/src/main/java/org/apache/hertzbeat/common/entity/grafana/Grafana.java
Show resolved
Hide resolved
common/src/main/java/org/apache/hertzbeat/common/entity/grafana/ServiceAccount.java
Show resolved
Hide resolved
common/src/main/java/org/apache/hertzbeat/common/entity/grafana/ServiceToken.java
Show resolved
Hide resolved
| import java.io.IOException; | ||
| import java.nio.charset.StandardCharsets; | ||
|
|
||
| import static org.apache.hertzbeat.common.constants.CommonConstants.FAIL_CODE; |
There was a problem hiding this comment.
Please merge the master branch code and configure checkstyle according to this; maybe the code style detection will fail.
There was a problem hiding this comment.
We've discussed not merging it for the time being, and will merge this pr as a new feature after an official stable release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Checklist
Add or update API