Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: build wheels for all macos versions including arm macos-14 #416

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

hussein-awala
Copy link
Member

closes: #397

This PR builds the wheels on 3 more macos versions, including macos-14 which will build a wheel compatible with arm. (link)

@Fokko
Copy link
Contributor

Fokko commented Feb 13, 2024

Thanks @hussein-awala for working on this. I think ARM builds would be great. I ran this against my own repository, but it looks like macos-14 does not support Python 3.8: https://github.com/Fokko/iceberg-python/actions/runs/7884003499 Maybe we can add an exception there?

@hussein-awala
Copy link
Member Author

Yeah, setup-python doesn't provide an arm-compatible build (actions/setup-python#705), I will try to implement a workaround for this, which I use for my projects.

@Fokko
Copy link
Contributor

Fokko commented Feb 13, 2024

@hussein-awala Thanks! It would be great to get this in 🚀

@hussein-awala
Copy link
Member Author

Actually, it's much simpler than I thought, the installed Python is only used to install poetry, then we build the wheels for the range of Python version, so bumping the Python version in the CI to 3.11 will fix the issue.

I just tested in my fork: https://github.com/hussein-awala/iceberg-python/actions/runs/7892158014/job/21538034351, it created the arm wheels and the wheels for the different macos versions.

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hussein-awala Just checked it here: https://github.com/Fokko/iceberg-python/actions/runs/7893318186 because I could not see the content of the artifact. It looks great! Thanks!

@Fokko Fokko merged commit 970c977 into apache:main Feb 13, 2024
6 checks passed
@hussein-awala
Copy link
Member Author

Great 🎉

Could we create a new RC (RC6) to test the creation of the wheels before voting?

@Fokko
Copy link
Contributor

Fokko commented Feb 13, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build wheels for all architectures
2 participants