IGNITE-17811 Efficiently unlock all transaction locks #2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto ignite-17811
…nto ignite-17811
…nto ignite-17811
…nto ignite-17811
…nto ignite-17811 � Conflicts: � modules/runner/src/integrationTest/java/org/apache/ignite/internal/benchmark/AbstractOneNodeBenchmark.java � modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java � modules/table/src/testFixtures/java/org/apache/ignite/internal/table/impl/DummyInternalTableImpl.java � modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/ReadWriteTransactionImpl.java � modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/TxManagerImpl.java
…nto ignite-17811 � Conflicts: � modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java � modules/table/src/testFixtures/java/org/apache/ignite/internal/table/impl/DummyInternalTableImpl.java
…nto ignite-17811 � Conflicts: � modules/table/src/integrationTest/java/org/apache/ignite/distributed/ItTxDistributedTestSingleNode.java � modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java
sk0x50
reviewed
Nov 24, 2023
modules/table/src/main/java/org/apache/ignite/internal/table/RecordBinaryViewImpl.java
Outdated
Show resolved
Hide resolved
…nto ignite-17811 � Conflicts: � modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/HeapLockManager.java
sk0x50
reviewed
Dec 5, 2023
| @Override | ||
| public void accept(Void unused) { | ||
| try { | ||
| Thread.sleep(500); |
There was a problem hiding this comment.
What is the purpose of this sleep here? Looks like a debugging code.
sanpwc
reviewed
Dec 5, 2023
...nner/src/integrationTest/java/org/apache/ignite/internal/benchmark/LockManagerBenchmark.java
Show resolved
Hide resolved
| } | ||
|
|
||
| @Test | ||
| @Disabled("https://issues.apache.org/jira/browse/IGNITE-20894") |
There was a problem hiding this comment.
Do we have given deadlock issue in current main? @Cyrill claims that we don't.
There was a problem hiding this comment.
It perfectly hangs to me
https://github.com/apache/ignite-3/tree/tx_deadlock_recovery_hang
There was a problem hiding this comment.
There is a replication timeout in log which is most probable reason why the test hangs. After I merged fresh main to tx_deadlock_recovery_hang branch, it doesn't hang anymore.
modules/table/src/integrationTest/java/org/apache/ignite/distributed/ItLockTableTest.java
Outdated
Show resolved
Hide resolved
modules/table/src/integrationTest/java/org/apache/ignite/distributed/ItLockTableTest.java
Show resolved
Hide resolved
modules/table/src/integrationTest/java/org/apache/ignite/distributed/ItLockTableTest.java
Show resolved
Hide resolved
modules/transactions/src/main/java/org/apache/ignite/internal/tx/LockKey.java
Show resolved
Hide resolved
modules/transactions/src/main/java/org/apache/ignite/internal/tx/LockManager.java
Show resolved
Hide resolved
modules/transactions/src/main/java/org/apache/ignite/internal/tx/LockManager.java
Outdated
Show resolved
Hide resolved
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/HeapLockManager.java
Show resolved
Hide resolved
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/HeapLockManager.java
Outdated
Show resolved
Hide resolved
denis-chudov
reviewed
Dec 6, 2023
...le/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java
Show resolved
Hide resolved
…nto ignite-17811 � Conflicts: � modules/table/src/testFixtures/java/org/apache/ignite/internal/table/impl/DummyInternalTableImpl.java � modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/HeapLockManager.java
sanpwc
approved these changes
Dec 12, 2023
…nto ignite-17811 � Conflicts: � modules/table/src/testFixtures/java/org/apache/ignite/internal/table/impl/DummyInternalTableImpl.java
|
I dont have any objections except that we should get a green visa to merge this. |
denis-chudov
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-17811