Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Enable window.sql in GlutenSQLQueryTestSuite #5500

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JkSelf
Copy link
Contributor

@JkSelf JkSelf commented Apr 23, 2024

What changes were proposed in this pull request?

Enable window.sql test in GlutenSQLQueryTestSuite.

How was this patch tested?

new unit tests.

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

@FelixYBW
Copy link
Contributor

Do we have you list of window functions/features which still fallback?

@JkSelf
Copy link
Contributor Author

JkSelf commented Apr 24, 2024

Do we have you list of window functions/features which still fallback?

@FelixYBW

  • Window Function fallback: Support for all window functions is available. However, additional testing may be required for specific data types and core case scenarios.
  • Feature fallback: RangeFrame Fallback Considerations: 1) Literal Fallback: For instance, 'RANGE BETWEEN 5 PRECEDING AND 5 FOLLOWING'; 2) Unsupported DESC in ORDER BY. 3) ORDER BY Data Type Limitation: Only integral data types are supported for ordering (byte, short, integer, long). 4) Negative upper bounds and positive lower bounds are not supported.

Copy link

Run Gluten Clickhouse CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants