Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DNM][GLUTEN-5548][VL] test dynamic setting #5506

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

[DNM][GLUTEN-5548][VL] test dynamic setting #5506

wants to merge 7 commits into from

Conversation

zhli1142015
Copy link
Contributor

@zhli1142015 zhli1142015 commented Apr 23, 2024 •
edited

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

Fixes: #5548

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@github-actions GitHub Actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@zhli1142015
Copy link
Contributor Author

/Benchmark Velox

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_5506_time.csv log/native_master_04_22_2024_b4641c9eb_time.csv difference percentage
q1 35.46 36.84 1.374 103.88%
q2 23.86 26.10 2.237 109.38%
q3 35.58 37.15 1.564 104.39%
q4 41.24 40.55 -0.689 98.33%
q5 70.09 71.41 1.314 101.87%
q6 7.25 7.43 0.174 102.40%
q7 84.93 85.19 0.262 100.31%
q8 83.88 87.61 3.730 104.45%
q9 120.93 125.61 4.684 103.87%
q10 44.99 44.30 -0.690 98.47%
q11 20.76 20.56 -0.201 99.03%
q12 24.92 25.45 0.538 102.16%
q13 48.84 57.20 8.359 117.11%
q14 18.41 17.68 -0.731 96.03%
q15 31.05 30.05 -1.004 96.77%
q16 14.39 12.69 -1.696 88.21%
q17 105.31 100.75 -4.561 95.67%
q18 145.83 144.04 -1.790 98.77%
q19 13.69 14.98 1.288 109.41%
q20 28.90 28.30 -0.602 97.92%
q21 229.32 285.90 56.579 124.67%
q22 15.12 14.83 -0.289 98.09%
total 1244.77 1314.62 69.852 105.61%

@zhli1142015
Copy link
Contributor Author

/Benchmark Velox

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_5506_time.csv log/native_master_04_23_2024_fd2519a2b_time.csv difference percentage
q1 36.41 36.36 -0.056 99.85%
q2 23.54 24.01 0.464 101.97%
q3 35.44 36.90 1.463 104.13%
q4 39.24 39.08 -0.157 99.60%
q5 69.83 69.94 0.106 100.15%
q6 5.68 7.58 1.899 133.44%
q7 82.94 86.14 3.200 103.86%
q8 85.51 85.13 -0.383 99.55%
q9 118.76 122.27 3.511 102.96%
q10 44.45 43.15 -1.294 97.09%
q11 21.62 21.01 -0.605 97.20%
q12 26.51 27.87 1.353 105.10%
q13 47.32 55.25 7.931 116.76%
q14 17.97 20.45 2.482 113.81%
q15 33.58 28.88 -4.703 85.99%
q16 14.01 14.54 0.535 103.82%
q17 103.85 106.73 2.881 102.77%
q18 149.26 147.26 -2.009 98.65%
q19 14.83 13.90 -0.931 93.72%
q20 30.76 28.89 -1.872 93.91%
q21 228.89 295.12 66.232 128.94%
q22 15.43 17.71 2.279 114.77%
total 1245.83 1328.16 82.324 106.61%

@zhli1142015 zhli1142015 changed the title [DNR] test dynamic setting [DNM][GLUTEN-5548] test dynamic setting Apr 26, 2024
@zhli1142015 zhli1142015 changed the title [DNM][GLUTEN-5548] test dynamic setting [DNM][GLUTEN-5548][VL] test dynamic setting Apr 26, 2024
@zhli1142015
Copy link
Contributor Author

/Benchmark Velox

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_5506_time.csv log/native_master_04_28_2024_b62bc2f38_time.csv difference percentage
q1 36.10 36.73 0.637 101.77%
q2 28.30 23.98 -4.320 84.74%
q3 37.85 35.10 -2.752 92.73%
q4 37.99 37.81 -0.181 99.52%
q5 70.31 69.95 -0.354 99.50%
q6 5.68 7.13 1.453 125.58%
q7 81.98 81.33 -0.655 99.20%
q8 87.61 85.39 -2.221 97.46%
q9 123.19 126.38 3.192 102.59%
q10 43.85 42.90 -0.948 97.84%
q11 19.69 19.70 0.011 100.06%
q12 21.41 25.40 3.988 118.63%
q13 53.83 55.90 2.068 103.84%
q14 18.42 17.43 -0.988 94.64%
q15 29.51 30.27 0.759 102.57%
q16 14.42 13.72 -0.703 95.13%
q17 102.78 104.54 1.767 101.72%
q18 148.41 145.60 -2.814 98.10%
q19 13.59 13.48 -0.113 99.17%
q20 32.26 31.00 -1.256 96.10%
q21 224.69 286.75 62.055 127.62%
q22 14.42 14.38 -0.040 99.72%
total 1246.28 1304.87 58.586 104.70%

@zhli1142015
Copy link
Contributor Author

/Benchmark Velox

1 similar comment
@zhli1142015
Copy link
Contributor Author

/Benchmark Velox

@zhli1142015
Copy link
Contributor Author

/Benchmark Velox

1 similar comment
@zhli1142015
Copy link
Contributor Author

/Benchmark Velox

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_5506_time.csv log/native_master_05_07_2024_254d62e72_time.csv difference percentage
q1 34.21 34.69 0.481 101.41%
q2 23.41 23.52 0.105 100.45%
q3 36.49 39.12 2.635 107.22%
q4 34.50 38.99 4.491 113.02%
q5 69.33 70.47 1.134 101.64%
q6 7.19 7.99 0.806 111.21%
q7 80.88 82.58 1.703 102.11%
q8 87.46 85.88 -1.580 98.19%
q9 119.81 125.69 5.883 104.91%
q10 45.02 44.17 -0.855 98.10%
q11 22.48 19.52 -2.966 86.81%
q12 26.48 25.07 -1.408 94.68%
q13 53.14 54.78 1.640 103.09%
q14 18.02 16.46 -1.553 91.38%
q15 33.01 29.15 -3.854 88.32%
q16 14.13 14.27 0.143 101.01%
q17 101.70 104.34 2.640 102.60%
q18 145.94 144.89 -1.040 99.29%
q19 13.41 15.16 1.745 113.01%
q20 30.44 26.39 -4.051 86.69%
q21 260.34 283.25 22.913 108.80%
q22 12.25 14.47 2.219 118.12%
total 1269.63 1300.85 31.229 102.46%

@zhli1142015
Copy link
Contributor Author

/Benchmark Velox

@zhli1142015
Copy link
Contributor Author

/Benchmark Velox

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_5506_time.csv log/native_master_05_09_2024_949650969_time.csv difference percentage
q1 33.81 34.78 0.969 102.87%
q2 23.32 23.41 0.091 100.39%
q3 36.55 37.42 0.870 102.38%
q4 35.57 38.34 2.775 107.80%
q5 68.61 70.90 2.289 103.34%
q6 7.68 7.35 -0.334 95.65%
q7 79.81 80.34 0.525 100.66%
q8 86.48 83.85 -2.629 96.96%
q9 119.69 121.16 1.466 101.23%
q10 43.39 46.73 3.336 107.69%
q11 22.26 19.94 -2.319 89.58%
q12 26.05 27.24 1.185 104.55%
q13 51.91 53.72 1.805 103.48%
q14 20.83 18.93 -1.902 90.87%
q15 32.38 29.19 -3.194 90.14%
q16 13.39 13.91 0.517 103.86%
q17 96.63 103.03 6.402 106.63%
q18 137.82 146.45 8.636 106.27%
q19 13.32 16.62 3.292 124.71%
q20 27.02 25.96 -1.063 96.07%
q21 259.84 280.52 20.681 107.96%
q22 12.52 14.69 2.163 117.27%
total 1248.90 1294.46 45.563 103.65%

@zhli1142015
Copy link
Contributor Author

/Benchmark Velox

2 similar comments
@zhli1142015
Copy link
Contributor Author

/Benchmark Velox

@zhli1142015
Copy link
Contributor Author

/Benchmark Velox

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_5506_time.csv log/native_master_05_09_2024_949650969_time.csv difference percentage
q1 34.11 34.78 0.672 101.97%
q2 23.65 23.41 -0.238 98.99%
q3 37.37 37.42 0.057 100.15%
q4 39.71 38.34 -1.368 96.55%
q5 66.83 70.90 4.074 106.10%
q6 7.18 7.35 0.174 102.43%
q7 82.27 80.34 -1.929 97.65%
q8 84.35 83.85 -0.499 99.41%
q9 121.69 121.16 -0.527 99.57%
q10 43.11 46.73 3.614 108.38%
q11 22.20 19.94 -2.261 89.82%
q12 25.05 27.24 2.181 108.71%
q13 55.51 53.72 -1.791 96.77%
q14 19.16 18.93 -0.236 98.77%
q15 32.39 29.19 -3.204 90.11%
q16 14.29 13.91 -0.388 97.28%
q17 94.53 103.03 8.505 109.00%
q18 137.18 146.45 9.270 106.76%
q19 13.47 16.62 3.145 123.34%
q20 26.36 25.96 -0.401 98.48%
q21 282.73 280.52 -2.210 99.22%
q22 14.59 14.69 0.093 100.64%
total 1277.72 1294.46 16.734 101.31%

@zhli1142015
Copy link
Contributor Author

/Benchmark Velox

1 similar comment
@zhli1142015
Copy link
Contributor Author

/Benchmark Velox

@zhli1142015
Copy link
Contributor Author

/Benchmark Velox

1 similar comment
@zhli1142015
Copy link
Contributor Author

/Benchmark Velox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[VL] Performance regression since 4.12
2 participants
@zhli1142015 @GlutenPerfBot