Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend adapter setup to support Debian distributions #5540

Closed
wants to merge 1 commit into from

Conversation

Preetesh2110
Copy link

What changes were proposed in this pull request?

Extend adapter setup to support Debian distributions

This change allows the setup script to work on both Ubuntu and Debian,
increasing its portability across common Linux environments.

How was this patch tested?

Manual build was successful.

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@Preetesh2110
Copy link
Author

@acvictor could you please take a look at it. Thanks

@acvictor
Copy link
Contributor

acvictor commented Apr 25, 2024

@acvictor could you please take a look at it. Thanks

@Preetesh2110 let's update this in Velox directly? It will become painful to maintain every time the upstream file changes. I can raise a PR. LMK!

@surnaik
Copy link
Contributor

surnaik commented Apr 25, 2024

Hi @acvictor, nice to hear from you. Sure, please raise it in upstream velox. That seems like the right place. Thanks @Preetesh2110 for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants