Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Fallback Window operator if there is a mismatch in output type #5554

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JkSelf
Copy link
Contributor

@JkSelf JkSelf commented Apr 26, 2024

What changes were proposed in this pull request?

Fallback Window operator if there is a mismatch in output types.

How was this patch tested?

adding new unit test

@JkSelf
Copy link
Contributor Author

JkSelf commented Apr 26, 2024

@FelixYBW

@FelixYBW
Copy link
Contributor

Is it spark only? if Not is it easy to fix in Velox? Can you open an issue to track in Velox?

Let's merge this until it's fixed in Velox.

Copy link

Run Gluten Clickhouse CI

@JkSelf JkSelf changed the title [VL] Fallback Window operator if there is a mismatch between the functions's input and output types. [VL] Fallback Window operator if there is a mismatch in output type May 14, 2024
Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

@JkSelf
Copy link
Contributor Author

JkSelf commented May 15, 2024

Is it spark only? if Not is it easy to fix in Velox? Can you open an issue to track in Velox?

Let's merge this until it's fixed in Velox.

@FelixYBW This is a bug in velox. Fixed in facebookincubator/velox#9818

Copy link

Run Gluten Clickhouse CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants