Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Pass file size and modification time to split #5632

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

acvictor
Copy link
Contributor

@acvictor acvictor commented May 7, 2024

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

(Fixes: #ISSUE-ID)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Copy link

github-actions bot commented May 7, 2024

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

github-actions bot commented May 7, 2024

Run Gluten Clickhouse CI

@FelixYBW
Copy link
Contributor

FelixYBW commented May 7, 2024

Can you comment a bit how these info are used by Velox? Is it aligned with Spark's behavior?

@gaoyangxiaozhu
Copy link
Contributor

can't we leverage metadatacolumns for this since it already contains fileSize and modifyTime ?

@acvictor
Copy link
Contributor Author

can't we leverage metadatacolumns for this since it already contains fileSize and modifyTime ?

Does metadatacolumns always contain file size and modification time? I understood it as containing these only if they are being queried. In this case I want it to always be passed in the split.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants