New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] Spark width_bucket function support #5634
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
Run Gluten Clickhouse CI |
fail due to Velox @zhouyuan @PHILO-HE and @zhli1142015 , may basic c++ question, do you know how to modify velox widthBatch function to let it support return null value for those specifal cases as the result type already be set to int64_t ? |
Velox uses Presto implementation. You may need to create a new function for Velox/Spark, and pass the reference of null set to the function. |
Summary: Doc: https://spark.apache.org/docs/latest/api/sql/#width_bucket Code: https://github.com/apache/spark/blob/3b1ea0fde44ec0aef8af24ca9a0a218a1c2d487d/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala#L1746C1-L1790C1 this is a dependency PR for fixing failure of apache/incubator-gluten#5634 Pull Request resolved: #9743 Reviewed By: xiaoxmeng Differential Revision: D57658402 Pulled By: mbasmanova fbshipit-source-id: b7f35225c260be95869884676d8e253a3a0a0786
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
@rui-mo help review , thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
velox already support
width_bucket
function#4039
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)