Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL][DOC] Suggest enable vcpkg for docker build in centos #5641

Closed
wants to merge 1 commit into from

Conversation

zml1206
Copy link
Contributor

@zml1206 zml1206 commented May 7, 2024

What changes were proposed in this pull request?

As title.

How was this patch tested?

Local build test.

Copy link

github-actions bot commented May 7, 2024

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@FelixYBW
Copy link
Contributor

FelixYBW commented May 7, 2024

Actually we are going to enable vcpkg=on as default. The dynamic build script is still there but CI won't track it.
@weiting-chen

@zml1206
Copy link
Contributor Author

zml1206 commented May 8, 2024

Actually we are going to enable vcpkg=on as default. The dynamic build script is still there but CI won't track it. @weiting-chen

Default on is more friendly to novices like me. I initially tried disable vcpkg and add the gluten-package-${Maven-artifact-version}.jar to extraClassPath then set spark.gluten.loadLibFromJar=true, but it run failed.

@ulysses-you
Copy link
Contributor

@FelixYBW @weiting-chen @zhouyuan I believe there is an issue #5033 before going to enbale vcpkg by default ?

@zml1206
Copy link
Contributor Author

zml1206 commented May 13, 2024

Enable vcpkg=on as default is going on, so close it.

@zml1206 zml1206 closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants