[GLUTEN-5696] Add preprojection support for ArrowEvalPythonExec #5697
+149
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
@jinchengchenghh @zhouyuan please help take a review. Thanks. |
| @@ -738,5 +739,7 @@ trait SparkPlanExecApi { | |||
|
|
|||
| def genPostProjectForGenerate(generate: GenerateExec): SparkPlan | |||
|
|
|||
| def genPreProjectForArrowEvalPythonExec(arrowEvalPythonExec: ArrowEvalPythonExec): SparkPlan | |||
There was a problem hiding this comment.
Can default return arrowEvalPythonExec, and remove the change in CH backend
|
Run Gluten Clickhouse CI |
| val argOffsets = inputs.map { | ||
| input => | ||
| input.map { | ||
| e => | ||
| if (allInputs.exists(_.semanticEquals(e))) { | ||
| allInputs.indexWhere(_.semanticEquals(e)) | ||
| } else { | ||
| if (!e.isInstanceOf[AttributeReference]) { |
There was a problem hiding this comment.
else if (!e.isInstanceOf[AttributeReference]) {}
else {}
...ds-velox/src/main/scala/org/apache/gluten/execution/python/ColumnarArrowEvalPythonExec.scala
Show resolved
Hide resolved
| // flatten all the arguments | ||
| val allInputs = new ArrayBuffer[Expression] | ||
| for (input <- inputs) { | ||
| input.map { |
There was a problem hiding this comment.
input.filter(allInputs.exists(_.semanticEquals(e))
There was a problem hiding this comment.
This line is not to filter the inputs but add the matched expression in allInputs and replace it using faked Attribute.
backends-velox/src/test/scala/org/apache/gluten/execution/python/ArrowEvalPythonExecSuite.scala
Outdated
Show resolved
Hide resolved
backends-velox/src/test/scala/org/apache/gluten/execution/python/ArrowEvalPythonExecSuite.scala
Outdated
Show resolved
Hide resolved
|
Run Gluten Clickhouse CI |
jinchengchenghh
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add preprojection support for ArrowEvalPythonExec
Fixes: #5696)
How was this patch tested?
New UTs added