[Kogito-2195] Kogito examples with ansible automation #258

desmax74 · 2020-05-15T15:02:49Z

https://issues.redhat.com/browse/KOGITO-2195
@sterobin @danielezonca

sterobin · 2020-05-15T15:33:40Z

@danielezonca , @krisv , @ricardozanini , @radtriste , who should we add as dev reviewers and QE reviewers (if applicable) for this to get it worked in and approved for the examples? Max and I apparently don't have permissions to add reviewers officially.

jiripetrlik

@desmax74
Hello! Thank you for your PR. I've put the first review here. Unfortunately I was not able to test it because the setup is for Ubuntu/Debian. Can you please add setup also for some RedHat like systems such as Fedora?

jiripetrlik · 2020-05-18T09:32:09Z

kogito-ansible/README.md

+Ansible scripts to automate creation of CRC cluster and the deploy of one of the Kogito examples with just one command line.
+
+CRC 1.10.0, and Ansible must be installed.
+No previous CRC setup (no /home/{user}/.crc folder), otherwise the create script will fail, delete .crc if you want run more than once the create playbook


Please make this optional. User may want to use his already CRC deployed cluster. It is probably not good to force user to remove all his previous CRC setup.

jiripetrlik · 2020-05-18T09:33:39Z

kogito-ansible/README.md

+### Install CRC
+(If you haven't already installed)
+
+Pre requisite on Debian/Ubuntu:


Please provide version of Ubuntu and Debian on which you have tested these scripts.

jiripetrlik · 2020-05-18T09:35:01Z

kogito-ansible/README.md

+```sh
+sudo ansible-playbook ./playbook_etc_hosts.yaml
+```
+


Please provide setup also for Fedora.

I'll create two sections in the doc since is all for fedora and only the lib virt installation is the first step on ubuntu

jiripetrlik · 2020-05-18T09:43:03Z

kogito-ansible/playbook_libs.yaml

+  tasks:
+
+    - name: install
+      shell: "sudo apt install qemu-kvm libvirt-daemon libvirt-daemon-system network-manager -y"


Please use "apt" module instead of shell. https://docs.ansible.com/ansible/latest/modules/apt_module.html#apt-module

jiripetrlik · 2020-05-18T09:46:39Z

kogito-ansible/playbook_libs.yaml

+    - name: install
+      shell: "sudo apt install qemu-kvm libvirt-daemon libvirt-daemon-system network-manager -y"
+      become: yes
+      when: ansible_os_family == 'Debian'


Please check that os family is supported using assert module instead of silently skipping installation of libvirt libraries.
https://docs.ansible.com/ansible/latest/modules/assert_module.html#assert-module

jiripetrlik · 2020-05-18T09:55:30Z

kogito-ansible/playbook_create.yaml

+      - name: Copy Kogito cli
+        get_url:
+          url: "https://github.com/kiegroup/kogito-cloud-operator/releases/download/{{ kogito_tag }}/kogito-cli-{{ kogito_tag }}-linux-amd64.tar.gz"
+          dest: "/tmp/kogito-{{ kogito_tag }}-linux-amd64.tar.gz"


Again please create variable for this temporary destination with default value. Or you can also consider to use "tempfile" module. https://docs.ansible.com/ansible/latest/modules/tempfile_module.html#tempfile-module

jiripetrlik · 2020-05-18T09:58:59Z

kogito-ansible/playbook_etc_hosts.yaml

+
+  tasks:
+
+  - name: Check api in hosts


Isn't DNS reconfigured by CRC itself.

I have to check with the latest version, because with old version of crc without this manual addition on /etc/hosts the cluster was unreachable

jiripetrlik · 2020-05-18T10:04:12Z

kogito-ansible/playbook_create.yaml

+      kogito_tag: "0.10.0"
+      ram: "16384" #MB
+      libvirt_version: "4.4.3"
+      ip_on_etc_hosts: 192.168.130.11


Please do not use this value which can probably change on different machine etc. It would be much better to use "virt" or "virt_net" modules to obtain info about IP address.

https://docs.ansible.com/ansible/latest/modules/virt_module.html#virt-module

https://docs.ansible.com/ansible/latest/modules/virt_net_module.html#virt-net-module

jiripetrlik · 2020-05-18T10:04:47Z

kogito-ansible/playbook_create.yaml

+---
+  - name: Start CRC 1.10.0 and deploy Kogito Operator and CLI
+    hosts: localhost
+    gather_facts: true


Do we really need to explicitly run this?

No, was just to describe the version used, we could use a placeholder and print the version used instead to updated this on every update

jiripetrlik · 2020-05-18T10:05:23Z

kogito-ansible/playbook_crc.yaml

+---
+- name: Install CRC
+  hosts: localhost
+  gather_facts: true


Isn't this done by default?

No, is disabled by default to save time, but to read the current user infos is needed

jiripetrlik · 2020-05-18T10:11:30Z

@sterobin Hello I did the first QE review for this.

desmax74 · 2020-05-18T10:17:11Z

@jiripetrlik These scripts are developed and tested on Fedora 31, only the playbook_scripts is for ubuntu if is the system used.

jiripetrlik · 2020-05-18T10:26:52Z

@desmax74 It seems to me that "playbook_libs.yaml" is developed for Ubuntu isn't it? And as libvirts setup is necessary for whole setup we probably need alternative for Fedora. Do you agree?

desmax74 · 2020-05-18T10:50:28Z

@jiripetrlik yep, only playbook_libs.yaml is for ubuntu, if isn't clear the description "Pre requisite on Debian/Ubuntu:
Install libvirt libs on Debian/Ubuntu only:" " I could change.
Libvirt was already present on Fedora iirc.

jiripetrlik · 2020-05-18T11:25:01Z

@desmax74
I would suggest to install "dnf install @Virtualization" to be sure. Please use proper package module of Ansible to do that. Or check if libvirtd is running and in case that it does not install virtualization packages. To be honest don't know which packages are installed by default. But it may probably differ on Fedora type, such as desktop or server. Or it may be different for Fedora spins.

See documentation for Fedora virtualization packages: https://docs.fedoraproject.org/en-US/quick-docs/getting-started-with-virtualization/

danielezonca

Thanks for the PR :)
Some comments

kogito-ansible/README.md

kogito-ansible/playbook_crc.yaml

kogito-ansible/playbook_create.yaml

danielezonca · 2020-05-25T06:35:44Z

kogito-ansible/playbook_create.yaml

+    vars:
+      kogito_tag: "0.10.0"
+      ram: "16384" #MB
+      libvirt_version: "4.4.3"


Why is this value hardcoded?

Because is used in the path and you discover the version only when the crc is downloaded and unpacked, or readed from the lates json info

I've writed a version to use the latest kogito tag, but the 0.10.1 doesn't work because the cli and the operator aren't aligned (kogito 0.10.1 - kogito-cloud-operator 0.10.0)

mmm I expect this could happen in the future too so is it possible to add a kogito-operator variable to support also this use case?

README.md

kogito-ansible/README.md

kogito-ansible/playbook_deploy.yaml

kogito-ansible/playbook_create.yaml

kogito-ansible/playbook_deploy.yaml

danielezonca · 2020-05-25T06:50:36Z

kogito-ansible/README.md

+
+
+
+## Ubuntu


Is this section actually different from the Fedora one?
They are really similar (the same?) from what I can see. Is it possible to create a single Fedora/Ubuntu section and just highlight different steps (if any).
This can reduce maintenance cost of this doc :)

Previously only one section plus the ubuntu lib virt installation was present but at the reviewer seems a document for ubuntu deploy and asked a fedora version, for this reason you see explicit configurations for both systems

I agree to have the instructions for Ubuntu and Fedora too but if they are the same just mention that the instructions are tested on both configuration instead of duplicate them :)

jiripetrlik · 2020-05-25T07:56:16Z

kogito-ansible/playbook_libs.yaml

+      when: ansible_os_family == 'Debian'
+
+    - name: Install Virtualization on Fedora
+      shell: "sudo dnf install @virtualization -y"


Please use Ansible DNF module instead https://docs.ansible.com/ansible/latest/modules/dnf_module.html#dnf-module

Something like this:
- name: Install Virtualization on Fedora
dnf:
name: "@Virtualization"
become: yes
when: ansible_os_family == 'RedHat'

…ersions

jiripetrlik · 2020-05-27T15:07:17Z

@desmax74
I've found two possible bugs when installing on fresh Ubuntu 20.04.

In playbook "playbook_crc", "crc libvirt group" task. Crc can not be found because folder ".local/bin" did not exist before running Ansible script, To workaround this it is necessary to reinitialize terminal and run command manually "crc config set skip-check-user-in-libvirt-group true"
In "playbook_create" in "Start CRC with 13312MB" task. I see the following error: "Failed to query DNS from host: lookup api.crc.testing: no such host"

desmax74 · 2020-05-27T15:34:47Z

@jiripetrlik

Why not just simply create the folder as a pre-task ?
I could re-apply kiegroup@654af19#diff-5ab00d684a07bbdf26507b898ba2a2ff

jiripetrlik · 2020-05-29T11:25:02Z

@desmax74
ad 1, I've moved "Create .local/bin/" task to pre_tasks but without any effect. It is still necessary to login and logout to have crc command on PATH.
ad 2, I've tried to run "kogito-ansible/playbook_etc_hosts.yaml" before playbook_create but it failed with the following error "Failed to query DNS from host: lookup foo.apps-crc.testing: no such host". I think we need to find more general solution than adding lines to hosts file for each domain. Is CRC supported on Debian/Ubuntu?

desmax74 · 2020-05-29T14:05:58Z

In the Ubuntu 20.04 bashrc isn't present the PATH="$HOME/.local/bin
I'll change the script to change the bashrc to re add like the 19.10

kogito-ansible/playbook_create.yaml

danielezonca

Approving 👍
@desmax74 can you please rebase from master to make the build green?

…o kogito-2195

…older removed in the 20.04

desmax74 · 2020-06-09T13:21:13Z

@jiripetrlik dropped ubuntu until we found a workaround, please review

jiripetrlik · 2020-06-16T09:01:52Z

@desmax74 Hello currently I'm getting following error on Fedora 32 : ""changed": true, "cmd": "crc setup", "delta": "0:03:00.977265", "end": "2020-06-16 10:31:41.176060", "msg": "non-zero return code", "rc": 1, "start": "2020-06-16 10:28:40.198795", "stderr": "level=fatal msg="Failed to start libvirt 'crc' network"", "stderr_lines"...

jiripetrlik · 2020-06-16T09:17:22Z

@desmax74 It also seems that there are some commits unrelated to PR and PR check failed. Can you please rebase properly?

…o kogito-2195

…ersions

domhanak · 2024-03-01T07:30:05Z

@krisv @mdproctor @ricardozanini do you have any information about this?

ricardozanini · 2024-03-01T12:57:34Z

I'd close it.

cristianonicolai and others added 2 commits April 21, 2020 06:53

Release of version 0.10.0

1e07b99

Kogito examples with ansible automation

654af19

This was referenced May 15, 2020

[Kogito-2195] Kogito Examples Ansible automation for CRC apache/incubator-kie-docs#2403

Closed

[Kogito-2195] Kogito Examples Ansible automation for CRC apache/incubator-kie-kogito-runtimes#509

Closed

jiripetrlik suggested changes May 18, 2020

View reviewed changes

desmax74 added 2 commits May 18, 2020 19:33

changes requested by reviewer

f3971c0

changes requested by reviewer

4dee7f9

danielezonca reviewed May 25, 2020

View reviewed changes

jiripetrlik reviewed May 25, 2020

View reviewed changes

desmax74 added 5 commits May 25, 2020 12:24

changes requested by reviewer

7c027cd

changes requested by reviewer

73d1f78

versions come from release/tag files

5eb0cda

specified exact amount of ram and added pretask to remove hardcoded v…

48847f8

…ersions

enabled the tag and ram input

85b42af

danielezonca reviewed May 29, 2020

View reviewed changes

kogito-ansible/playbook_create.yaml Show resolved Hide resolved

danielezonca approved these changes Jun 4, 2020

View reviewed changes

desmax74 added 4 commits June 9, 2020 13:11

Kogito examples with ansible automation

a0cc19a

changes requested by reviewer

d78b179

changes requested by reviewer

b188a30

changes requested by reviewer

d157a97

desmax74 added 2 commits June 9, 2020 13:12

Merge branch 'kogito-2195' of github.com:desmax74/kogito-examples int…

31ac8dd

…o kogito-2195

removed ubuntu support until we found a workaround to the loal user f…

cd77312

…older removed in the 20.04

max and others added 22 commits June 16, 2020 06:16

update

cd487d7

Merge branch 'kogito-2195' of github.com:desmax74/kogito-examples int…

2c80cf1

…o kogito-2195

update

fa52112

Kogito examples with ansible automation

be88c25

changes requested by reviewer

35f6e3a

changes requested by reviewer

da2fcb6

changes requested by reviewer

e76eb8e

changes requested by reviewer

260aa18

versions come from release/tag files

5489c7b

specified exact amount of ram and added pretask to remove hardcoded v…

1fae857

…ersions

enabled the tag and ram input

78f4018

Kogito examples with ansible automation

18c5e10

update

da06eff

changes requested by reviewer

bb7c906

changes requested by reviewer

4df8df3

changes requested by reviewer

f904f2c

versions come from release/tag files

0f04340

specified exact amount of ram and added pretask to remove hardcoded v…

ebd0d10

…ersions

update

87eb4ff

fix versions

7762734

fix versions

fc05cff

fix poms

7138182

domhanak added the stale This label is for items that are stale with no activity for more than a month label Mar 1, 2024

[Kogito-2195] Kogito examples with ansible automation #258

Are you sure you want to change the base?

[Kogito-2195] Kogito examples with ansible automation #258

Conversation

desmax74 commented May 15, 2020

sterobin commented May 15, 2020 • edited

jiripetrlik left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

desmax74 May 18, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jiripetrlik commented May 18, 2020

desmax74 commented May 18, 2020

jiripetrlik commented May 18, 2020

desmax74 commented May 18, 2020

jiripetrlik commented May 18, 2020

danielezonca left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

desmax74 May 25, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jiripetrlik commented May 27, 2020

desmax74 commented May 27, 2020

jiripetrlik commented May 29, 2020

desmax74 commented May 29, 2020

danielezonca left a comment

Choose a reason for hiding this comment

desmax74 commented Jun 9, 2020

jiripetrlik commented Jun 16, 2020

jiripetrlik commented Jun 16, 2020

domhanak commented Mar 1, 2024

ricardozanini commented Mar 1, 2024

sterobin commented May 15, 2020 •

edited

desmax74 May 18, 2020 •

edited

desmax74 May 25, 2020 •

edited