[KOGITO-9231] Configure RestWorkItemHandler SSL behaviour through pro… #3185
Conversation
| public static WebClientOptions sslQuarkusWebClientOptions() { | ||
| WebClientOptions webClientOptions = new WebClientOptions(); | ||
|
|
||
| String certificateFilePath = ConfigProvider.getConfig().getOptionalValue(QUARKUS_HTTP_SSL_CERTIFICATE_FILE, String.class).orElse(null); |
There was a problem hiding this comment.
I think is better to call ConfigProvider.getConfig(), just once
Also, rather than using orElse(null) and later check if the variable is null, use Optional.ifPresent to set the options accordingly
|
(tests) - kogito-runtimes job Reproducerexport BUILD_MVN_OPTS_CURRENT=-T 1C -Dvalidate-formatting -Prun-code-coverage NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Test results:
Those are the test failures: org.kie.kogito.persistence.kafka.KafkaProcessInstancesIT.testFindByIdReadModeexpected: 5 but was: 0 org.kie.kogito.integrationtests.SecureResourceTest.testSecureResourcejava.lang.RuntimeException: Failed to start quarkus |
| <dependency> | ||
| <groupId>org.eclipse.microprofile.config</groupId> | ||
| <artifactId>microprofile-config-api</artifactId> | ||
| <version>2.0</version> |
There was a problem hiding this comment.
Version should be handled by bom, so it can be removed
There was a problem hiding this comment.
Probably this POM does not need to be modified once utils is moved to quarkus extension
|
|
||
| @Produces | ||
| @Named("quarkusWebClientOptions") | ||
| public WebClientOptions quarkusWebClientOptions() { |
There was a problem hiding this comment.
Actuallly, I think this should be the default bean, there is not need to have two
|
SonarCloud Quality Gate failed.
|
|
(tests) - kogito-runtimes job Reproducerexport BUILD_MVN_OPTS_CURRENT=-T 1C -Dvalidate-formatting -Prun-code-coverage NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Test results:
Those are the test failures: org.kie.kogito.persistence.kafka.KafkaProcessInstancesIT.testFindByIdReadModeexpected: 5 but was: 0 org.kie.kogito.integrationtests.SecureResourceTest.testSecureResourcejava.lang.RuntimeException: Failed to start quarkus |
Jira: https://issues.redhat.com/browse/KOGITO-9231