New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
code quality improvement: clear the issues reported by SonarLint Plugin in some Test classes #3727
Conversation
…in in APITest.java
请扫描所有模块,争取一次性解决此问题 |
另外请在你的本地绑定你的github信息,否者提交上的pr会无关联的github账号 |
好的。我看全项目 sonarlint 总共有 4000 多个 issue,还是按照模块来吧 |
Codecov Report
@@ Coverage Diff @@
## develop #3727 +/- ##
=============================================
+ Coverage 51.31% 51.33% +0.02%
+ Complexity 3576 3575 -1
=============================================
Files 646 645 -1
Lines 21809 21798 -11
Branches 2738 2738
=============================================
- Hits 11191 11190 -1
+ Misses 9480 9470 -10
Partials 1138 1138
|
这个改动没必要分成多个模块,因为改出问题了,ci是不会通过的 |
这个改动没必要分成多个模块,因为改出问题了,ci是不会通过的,或者你可以几个模块几个模块的来,比如先改测试用例相关 |
@@ -64,7 +64,7 @@ | |||
* | |||
* @author leizhiyuan | |||
*/ | |||
public class DefaultCoordinatorTest { | |||
class DefaultCoordinatorTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
报错了。这个public
先恢复过来吧。
额,为什么要关闭掉啊? |
你好,我在修复完一些 issues 之后,发现目前依赖 grpc 模块的 UT 无法运行。因为目前 protobuf 相关组件没有提供针对 Apple M1 的 osx-aarch_64 版本的 jar 包,即使直接指定 <os.detected.arch> 为 osx_x86_64 后仍然无法正常运行,所以目前修改的一些问题本人无法运行 UT。在跟踪完 protobuf/grpc 相关依赖的仓库 issue 后,发现这个问题似乎没有得到积极的跟进,最新的动态在 |
Ⅰ. Describe what this PR did
code quality improvement: clear the issues reported by SonarLint Plugin
Ⅱ. Does this pull request fix one issue?
fixes #3690
Ⅲ. Why don't you add test cases (unit test/integration test)?
I used the IDEA SonarLint plugin scanning the APITest.java file and it reported nothing
Ⅳ. Describe how to verify it
before the modification
after
Ⅴ. Special notes for reviews