Skip to content

Commit

Permalink
[MINOR] fix: Update outdated config: rss.writer.send.check.timeout ->…
Browse files Browse the repository at this point in the history
… rss.client.send.check.timeout.ms (#1734)

### What changes were proposed in this pull request?

Update outdated config: rss.writer.send.check.timeout -> rss.client.send.check.timeout.ms.

### Why are the changes needed?

The `rss.writer.send.check.timeout` configuration has been renamed to `rss.client.send.check.timeout.ms`, no longer in use.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

No need.
  • Loading branch information
rickyma committed May 22, 2024
1 parent d9b1d9f commit 168cf74
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ If you have packaged tgz with hadoop jars, the env of `HADOOP_HOME` is needn't s
rss.coordinator.remote.storage.path hdfs://cluster1/path,hdfs://cluster2/path
rss.writer.require.memory.retryMax 1200
rss.client.retry.max 50
rss.writer.send.check.timeout 600000
rss.client.send.check.timeout.ms 600000
rss.client.read.buffer.size 14m
```
5. start Coordinator
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ public void checkBlockSendResultTest() {
rssShuffleWriter.checkBlockSendResult(Sets.newHashSet(1L, 2L, 3L));
manager.clearTaskMeta(taskId);

// case 2: partial blocks aren't sent before spark.rss.writer.send.check.timeout,
// case 2: partial blocks aren't sent before spark.rss.client.send.check.timeout.ms,
// Runtime exception will be thrown
manager.addSuccessBlockIds(taskId, Sets.newHashSet(1L, 2L));
Throwable e2 =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,7 @@ public void checkBlockSendResultTest() {
rssShuffleWriter.checkBlockSendResult(Sets.newHashSet(1L, 2L, 3L));
successBlocks.clear();

// case 2: partial blocks aren't sent before spark.rss.writer.send.check.timeout,
// case 2: partial blocks aren't sent before spark.rss.client.send.check.timeout.ms,
// Runtime exception will be thrown
successBlocks.put("taskId", Sets.newHashSet(1L, 2L));
Throwable e2 =
Expand Down
2 changes: 1 addition & 1 deletion docs/coordinator_guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ This document will introduce how to deploy Uniffle coordinators.
rss.coordinator.remote.storage.path hdfs://cluster1/path,hdfs://cluster2/path
rss.writer.require.memory.retryMax 1200
rss.client.retry.max 100
rss.writer.send.check.timeout 600000
rss.client.send.check.timeout.ms 600000
rss.client.read.buffer.size 14m
```

Expand Down

0 comments on commit 168cf74

Please sign in to comment.