[#1149] fix: GC logs in JDK 11 do not include date and time stamps.

[qijiale76]

What changes were proposed in this pull request?

(Please outline the changes and how this PR fixes the issue.)

Why are the changes needed?

(Please clarify why the changes are needed. For instance,

1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, describe the bug.)

Fix: #1149

Does this PR introduce any user-facing change?

(Please list the user-facing changes introduced by your change, including

1. Change in user-facing APIs.
2. Addition or removal of property keys.)

No.

How was this patch tested?

(Please test your changes, and provide instructions on how to test it:

1. If you add a feature or fix a bug, add a test to cover your changes.
2. If you fix a flaky test, repeat it for many times to prove it works.)

Manually tested

[qijiale76]

According to this documentation https://openjdk.org/jeps/158, the correct format should be

-Xlog:gc[:[<output>][:[<decorators>][:<output-options>]]]

The previous option missed a : symbol, thus tags,time,uptime,level is not working

[jerqi]

@zhengchenyu Could you help review this pr?

[rickyma]

@zhengchenyu @qijiale76 Any process here?

[qijiale76]

I will push forward with this PR again this week.

[rickyma]

Do we support higher versions of JDK here, like JDK 21? @qijiale76

[jerqi]

Do we support higher versions of JDK here, like JDK 21? @qijiale76

We don't support high version now.

[rickyma]

We don't support high version now.

I have run Uniffle on JDK 21 and didn't find any issues. I think Uniffle is compatible with JDK 21 already.

[jerqi]

We don't support high version now.

I have run Uniffle on JDK 21 and didn't find any issues. I think Uniffle is compatible with JDK 21 already.

We should add a JDK 21 pipeline first.

[EnricoMi]

@qijiale76 can this go ahead?

[github-actions]

Test Results

 2 419 files  +14   2 419 suites  +14   4h 56m 55s ⏱️ -54s
   933 tests + 2     931 ✅ + 1   1 💤 ±0  1 ❌ +1 
10 819 runs  +28  10 804 ✅ +27  14 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 7aa6861. ± Comparison against base commit 168cf74.

♻️ This comment has been updated with latest results.

[EnricoMi]

@qijiale76 @zhengchenyu @jerqi is this ready for review?

[jerqi]

We support JDK 17, too. VIP use JDK 17.

[zhengchenyu]

I don't think we need to support all versions of the JDK, the user should configure it according to their own environment.
But the docker image is using JDK11, the pom is using JDK8. Then I don't know which version to support.

[jerqi]

I don't think we need to support all versions of the JDK, the user should configure it according to their own environment. But the docker image is using JDK11, the pom is using JDK8. Then I don't know which version to support.

You can see the pipelines https://github.com/apache/incubator-uniffle/blob/master/.github/workflows/build.yml to find which version to support. Spark supports JDK8, JDK11 and JDK17.

[zhengchenyu]

I don't think we need to support all versions of the JDK, the user should configure it according to their own environment. But the docker image is using JDK11, the pom is using JDK8. Then I don't know which version to support.

You can see the pipelines https://github.com/apache/incubator-uniffle/blob/master/.github/workflows/build.yml to find which version to support. Spark supports JDK8, JDK11 and JDK17.

OK, we should support JDK17!

[qijiale76]

I just fixed the issue causing the test failure. I'll test the Java 17 configuration tomorrow.