[Improvement] Using configOption in RssMRConfig #1304 #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zuston , could you please help reivew this pr . |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1333 +/- ##
============================================
+ Coverage 53.35% 54.31% +0.95%
+ Complexity 2690 2571 -119
============================================
Files 410 384 -26
Lines 23590 20082 -3508
Branches 2003 1910 -93
============================================
- Hits 12587 10907 -1680
+ Misses 10229 8497 -1732
+ Partials 774 678 -96 ☔ View full report in Codecov by Sentry. |
zuston
reviewed
Nov 28, 2023
| @@ -83,37 +83,37 @@ public static TaskAttemptID createMRTaskAttemptId( | |||
| public static ShuffleWriteClient createShuffleClient(JobConf jobConf) { | |||
| int heartBeatThreadNum = | |||
There was a problem hiding this comment.
I think we could create a rssConf based on the jobConf, and then use the RssConf's function like get() to retrieve the conf value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Using the ConfigOption to unify all client and server config style.
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?