[Improvement] Replace ConfigEntry with ConfigOption in RssSparkConfig… #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuston
reviewed
Dec 14, 2023
| public static final ConfigEntry<String> RSS_WRITER_PRE_ALLOCATED_BUFFER_SIZE = | ||
| createStringBuilder(new ConfigBuilder("spark.rss.writer.pre.allocated.buffer.size")) | ||
| .createWithDefault("16m"); | ||
| public static final ConfigOption<String> RSS_WRITER_BUFFER_SIZE = |
There was a problem hiding this comment.
This change is not correct, Please follow this example.
public static final ConfigOption<Long> RSS_CLIENT_SEND_SIZE_LIMITATION =
ConfigOptions.key("rss.client.send.size.limit")
.longType()
.defaultValue(1024 * 1024 * 16L)
.withDescription("The max data size sent to shuffle server");
There was a problem hiding this comment.
I have already changed it, please help me look at it again.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1365 +/- ##
============================================
+ Coverage 53.35% 54.16% +0.80%
- Complexity 2690 2714 +24
============================================
Files 410 398 -12
Lines 23590 21574 -2016
Branches 2003 2041 +38
============================================
- Hits 12587 11685 -902
+ Misses 10229 9176 -1053
+ Partials 774 713 -61 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… #1302
What changes were proposed in this pull request?
Following this project's Code of Conduct
Using the ConfigOption to unify all client and server config style.
Why are the changes needed?
Unify all client and server config style.
Does this PR introduce any user-facing change?
How was this patch tested?