New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Support Flink RSS. #1366
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1366 +/- ##
============================================
+ Coverage 53.22% 54.11% +0.89%
- Complexity 2715 2720 +5
============================================
Files 418 399 -19
Lines 23932 21633 -2299
Branches 2043 2051 +8
============================================
- Hits 12738 11707 -1031
+ Misses 10408 9208 -1200
+ Partials 786 718 -68 ☔ View full report in Codecov by Sentry. |
@chenglong-bigdata Can you help review the code? |
public void registerJob(JobShuffleContext context) { | ||
JobID jobID = context.getJobId(); | ||
if (shuffleWriteClient == null) { | ||
synchronized (RssShuffleMaster.class) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is a class object here, it may be heavier. Is the object RssShuffleMaster itself enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you helping to review the code! This PR still needs to be improved.
ok |
Is there a design doc for this one? I can help review this feature. |
Thank you for reviewing the code! The documentation is being improved. I will update it as soon as possible. Unit tests are still being added. |
I will continue to follow up on this PR. |
@chenglong-bigdata We will continue to follow up on this PR. |
What changes were proposed in this pull request?
I. Introduction
A. Background
An intermediate data set is the data set produced by an operator - either a source or any intermediate operation.
Why are the changes needed?
(Please clarify why the changes are needed. For instance,
Fix: # (issue)
Does this PR introduce any user-facing change?
(Please list the user-facing changes introduced by your change, including
No.
How was this patch tested?
(Please test your changes, and provide instructions on how to test it: