Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1304] Improvement(rss-client-mr): Using configOption in RssMRConfig #1427

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

myandpr
Copy link
Contributor

@myandpr myandpr commented Jan 9, 2024

What changes were proposed in this pull request?

as title, Using configOption in RssMRConfig

Why are the changes needed?

Fix: #1304

Does this PR introduce any user-facing change?

No.

How was this patch tested?

existing unit tests

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

Attention: 125 lines in your changes are missing coverage. Please review.

Comparison is base (5d027c0) 53.38% compared to head (1eddea0) 54.68%.

Files Patch % Lines
...apache/hadoop/mapreduce/v2/app/RssMRAppMaster.java 0.00% 39 Missing ⚠️
...java/org/apache/hadoop/mapreduce/MRClientConf.java 90.49% 22 Missing and 1 partial ⚠️
...rg/apache/hadoop/mapred/RssMapOutputCollector.java 0.00% 17 Missing ⚠️
...pache/hadoop/mapreduce/task/reduce/RssShuffle.java 0.00% 15 Missing ⚠️
...n/java/org/apache/hadoop/mapreduce/RssMRUtils.java 65.78% 13 Missing ⚠️
...java/org/apache/uniffle/common/config/RssConf.java 0.00% 13 Missing ⚠️
.../org/apache/uniffle/common/config/RssBaseConf.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1427      +/-   ##
============================================
+ Coverage     53.38%   54.68%   +1.30%     
- Complexity     2729     2730       +1     
============================================
  Files           422      402      -20     
  Lines         24046    21935    -2111     
  Branches       2051     2058       +7     
============================================
- Hits          12836    11995     -841     
+ Misses        10412     9213    -1199     
+ Partials        798      727      -71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@myandpr
Copy link
Contributor Author

myandpr commented Jan 9, 2024

Hi @zuston , would you help review this PR when you hava time?

@myandpr
Copy link
Contributor Author

myandpr commented Jan 11, 2024

Hi @jerqi @zuston , PTAL

@zuston
Copy link
Member

zuston commented Jan 12, 2024

Could you help review this? @zhengchenyu

@zhengchenyu
Copy link
Collaborator

I still have my doubts about MRClientConf, same with #1303.
I think MRClientConf should not be extended from RssBaseConf, but RssClientConf.

@jerqi
Copy link
Contributor

jerqi commented Jan 12, 2024

I still have my doubts about MRClientConf, same with #1303. I think MRClientConf should not be extended from RssBaseConf, but RssClientConf.

RssBaseConf may contain some config options which are dedicated to the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Using configOption in RssMRConfig
5 participants