New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1304] Improvement(rss-client-mr): Using configOption in RssMRConfig #1427
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1427 +/- ##
============================================
+ Coverage 53.38% 54.68% +1.30%
- Complexity 2729 2730 +1
============================================
Files 422 402 -20
Lines 24046 21935 -2111
Branches 2051 2058 +7
============================================
- Hits 12836 11995 -841
+ Misses 10412 9213 -1199
+ Partials 798 727 -71 ☔ View full report in Codecov by Sentry. |
Hi @zuston , would you help review this PR when you hava time? |
Could you help review this? @zhengchenyu |
I still have my doubts about MRClientConf, same with #1303. |
RssBaseConf may contain some config options which are dedicated to the server. |
What changes were proposed in this pull request?
as title, Using configOption in RssMRConfig
Why are the changes needed?
Fix: #1304
Does this PR introduce any user-facing change?
No.
How was this patch tested?
existing unit tests