Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1608][part-6] improvement(spark): verify the sent blocks count #1690

Merged
merged 2 commits into from May 15, 2024

Conversation

zuston
Copy link
Member

@zuston zuston commented May 11, 2024

What changes were proposed in this pull request?

Verify the sent blocks count in write tasks for spark

Why are the changes needed?

For #1608.
After introducing the reassign menchanism, the blocks' stored location will be dynamiclly changed.
To ensure possible or potenial bugs, it's necessary to introduce the block count.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing tests are enough to ensure safe

@zuston zuston requested a review from jerqi May 11, 2024 02:56
Copy link

github-actions bot commented May 11, 2024

Test Results

 2 391 files  ±0   2 391 suites  ±0   4h 56m 44s ⏱️ +20s
   928 tests ±0     927 ✅ ±0   1 💤 ±0  0 ❌ ±0 
10 754 runs  ±0  10 740 ✅ ±0  14 💤 ±0  0 ❌ ±0 

Results for commit bf09407. ± Comparison against base commit 313d4e0.

♻️ This comment has been updated with latest results.

@zuston
Copy link
Member Author

zuston commented May 11, 2024

PTAL @jerqi

@zuston
Copy link
Member Author

zuston commented May 14, 2024

PTAL @jerqi

Gentle ping @jerqi

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zuston zuston merged commit bc46d4a into apache:master May 15, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants