Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1608][part-7] improvement(doc): add doc and optimize reassign config options #1693

Merged
merged 2 commits into from May 15, 2024

Conversation

zuston
Copy link
Member

@zuston zuston commented May 11, 2024

What changes were proposed in this pull request?

  1. add docs about reassign mechanism
  2. rename the config from "rss.client.blockSendFailureRetry.enabled" to "rss.client.reassign.enabled"

Why are the changes needed?

Fix: #1608

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Needn't

Copy link

github-actions bot commented May 11, 2024

Test Results

 2 391 files  ±0   2 391 suites  ±0   4h 58m 9s ⏱️ + 1m 45s
   929 tests +1     928 ✅ +1   1 💤 ±0  0 ❌ ±0 
10 763 runs  +9  10 749 ✅ +9  14 💤 ±0  0 ❌ ±0 

Results for commit b746084. ± Comparison against base commit 313d4e0.

♻️ This comment has been updated with latest results.

jerqi
jerqi previously approved these changes May 14, 2024
Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@rickyma rickyma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zuston zuston merged commit de4b261 into apache:master May 15, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support client partition data reassign
3 participants