-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1673] fix(K8S): Fix the deployment of stable version K8S cluster #1694
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1694 +/- ##
============================================
- Coverage 54.86% 54.05% -0.81%
- Complexity 2358 2775 +417
============================================
Files 368 418 +50
Lines 16379 21821 +5442
Branches 1504 2054 +550
============================================
+ Hits 8986 11795 +2809
- Misses 6862 9280 +2418
- Partials 531 746 +215 ☔ View full report in Codecov by Sentry. |
cc @rickyma @zhengchenyu This is a break change for your deployment, please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upgrade seems quite trivial and looks good to me.
Please update the doc to indicate the minimum version of K8S supported in this PR?
We can also wait for some more time for more eyes?
deploy/kubernetes/operator/pkg/controller/sync/coordinator/coordinator.go
Show resolved
Hide resolved
I verified this patch in the AWS EKS 1.28. It's ok. @advancedxy Could you approve this pull request? |
…1694) ### What changes were proposed in this pull request? 1. Upgrade Go to 1.19, Because mac brew doesn't support to install older than 1.19 Go. 2. Upgrade K8S api to 0.24. Because 1.24.1 supports to run the tests in the Mac M1 local machine and supports autoscaling/v2 api. 3. Change v2beta2 to v2 4. Use log4j2 instead of log4j ### Why are the changes needed? Kubernetes 1.26 removed the v2beta2 api of auto scaling. So our operator can't deployed some stable version K8S cluster. So I try to upgrade the version of the client. Compatible solution will be very difficult and bring more burden to maintain. So I choose to upgrade directly. If some users use low version, they can revert this pull request and compile again. Fix: #1673 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? UT + Manual test.
What changes were proposed in this pull request?
Why are the changes needed?
Kubernetes 1.26 removed the v2beta2 api of auto scaling. So our operator can't deployed some stable version K8S cluster. So I try to upgrade the version of the client.
Compatible solution will be very difficult and bring more burden to maintain. So I choose to upgrade directly. If some users use low version, they can revert this pull request and compile again.
Fix: #1673
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT + Manual test.