Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[android] onloadmore of scroller is not executed when loadmoreoffset is not set #2802

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ghost
Copy link

@ghost ghost commented Aug 8, 2019

Brief Description of the PR

On the web and iOS, do not set "loadmoreoffset" can trigger the loadmore event, but not on Android.
This pr solved it.

Checklist

@ghost ghost requested review from Darin726, gubaojian and YorkShen as code owners August 8, 2019 14:50
@ghost
Copy link
Author

ghost commented Aug 8, 2019

I have a same pr, but Maven read timed out in CI build.
Now I want to rebase the newest commit, but the repo have too many changes and I have too many conflicts.So I just delete my repo, fork the repo and pull the request again.

@weex-bot
Copy link

weex-bot commented Aug 8, 2019

Warnings
⚠️ Current pr not bind the milestone
⚠️ If you update the code, maybe you should update the documentation and add the documentation link in the PR description. here is the guide about how to contribute documentation: https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document
Messages
📖 danger test finished.

Generated by 🚫 dangerJS against 9c2a66e

@ghost ghost requested a review from wqyfavor as a code owner August 9, 2019 01:39
Copy link
Contributor

@YorkShen YorkShen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase to master branch, as there is a conflict.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants