add enforcer rule for jdk version used in dependencies #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksumit
reviewed
Nov 18, 2023
| <!-- Ensure no dependencies are using incompatible versions of java --> | ||
| <enforceBytecodeVersion> | ||
| <maxJdkVersion>${java.version}</maxJdkVersion> | ||
| <ignoredScopes>test</ignoredScopes> |
There was a problem hiding this comment.
I don't know how frequent such a usecase is but i'm tempted to put <strict>true</strict> as well here. By default it's set to false and could lead to issues? Thoughts?
There was a problem hiding this comment.
I'll try it out. It is better to be as "strict" as possible for now :)
There was a problem hiding this comment.
This causing lots of breakages: jackson, lombok, log4j all trigger the enforcer rule now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
Prevents runtime issues where we depend on a dependency that requires a newer version of java to run.
Brief change log
Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.