Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Add Issue template for xtable project #427

Merged
merged 1 commit into from May 11, 2024

Conversation

daragu
Copy link
Contributor

@daragu daragu commented Apr 28, 2024

Important Read

  • Please ensure the GitHub issue is mentioned at the beginning of the PR

Fixed #426

What is the purpose of the pull request

Add Issue template for xtable project.

e.g

Brief change log

(for example:)

  • Fixed JSON parsing error when persisting state
  • Added unit tests for schema evolution

Verify this pull request

This pull request is a trivial rework / code cleanup without any test coverage.

@daragu
Copy link
Contributor Author

daragu commented Apr 28, 2024

cc @the-other-tim-brown, take a review when free, thanks.

@daragu daragu force-pushed the issue_temp branch 3 times, most recently from 3ecceb4 to d7d8a0b Compare April 29, 2024 02:36
@daragu
Copy link
Contributor Author

daragu commented Apr 29, 2024

Thanks @the-other-tim-brown for the suggestion. Patch is updated accordingly, can you please take another look?

@xtable-bot
Copy link

CI report:

Bot commands @xtable-bot supports the following commands:
  • @xtable-bot run azure re-run the last Azure build

@daragu
Copy link
Contributor Author

daragu commented May 11, 2024

hi @vinishjail97 can you help to take a look? thanks

Copy link
Contributor

@the-other-tim-brown the-other-tim-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@the-other-tim-brown the-other-tim-brown merged commit dfd0129 into apache:main May 11, 2024
1 check passed
@daragu daragu deleted the issue_temp branch May 13, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Issue template for xtable project
3 participants