Skip to content

Commit

Permalink
KAFKA-14728: Don't run 'spotlessScalaCheck' in CI (#13263)
Browse files Browse the repository at this point in the history
Blocks #13205.

Rationale:
- build works fine in trunk with Gradle 7.6 and spotless gradle plugin 6.13.0 for all currently used JDK versions (that is: JDK 8 / JDK 11 / JDK 17)
- however, recent spotless gradle plugin versions (6.14.+) support only JDK 11+ versions: https://github.com/diffplug/spotless/blob/main/plugin-gradle/CHANGES.md#6140---2023-01-26
- given a fact that Kafka still needs to support JDK 8 builds (until Kafka version 4.0) it is reasonable to simply remove spotless checks out of Jenkinsfile (and re-introduce them when the time comes).

For even more details see GitHub discussion here: #13205 (comment)

Reviewers: Ismael Juma <ismael@juma.me.uk>
  • Loading branch information
dejan2609 committed Feb 23, 2023
1 parent 61ece48 commit 97efdc6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Jenkinsfile
Expand Up @@ -20,7 +20,7 @@
def doValidation() {
sh """
./retry_zinc ./gradlew -PscalaVersion=$SCALA_VERSION clean compileJava compileScala compileTestJava compileTestScala \
spotlessScalaCheck checkstyleMain checkstyleTest spotbugsMain rat \
checkstyleMain checkstyleTest spotbugsMain rat \
--profile --continue -PxmlSpotBugsReport=true -PkeepAliveMode="session"
"""
}
Expand Down

0 comments on commit 97efdc6

Please sign in to comment.