Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLUME-3354. Fix compilation error against Hive 2.3.5 and above. #315

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

iwasakims
Copy link
Member

No description provided.

Copy link
Contributor

@tmgstevens tmgstevens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.
Two questions:

  1. Do we need to do any testing against new Hive features?
  2. Did you attempt to compile this against Hive3?

@iwasakims
Copy link
Member Author

Do we need to do any testing against new Hive features?

I would like to focus on whether existing use case works or not here. All unit tests of flume-hive-sink passed on my local. I ran the tests on flume-1.9 branch since trunk does not compile on flume-thrift-source (which is not related to this fix).

@iwasakims
Copy link
Member Author

Did you attempt to compile this against Hive3?

No. I'm working on this for BIGTOP-3123 which assumes Hadoop 2.10.0. Hive 3.x does not support Hadoop 2.x.

We are planning to upgrade Hadoop to 3.x on the release after the next. We need to upgrade Hive to 3.x for that. When I tried to compile Flume with -Dhadoop.version=3.2.1 -Dhive.version=3.1.2 , there was compilation error on flume-hdfs-sink. I will file a JIRA later if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants