Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLUME-3320 Fix taildir source reset position bug #368

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

iijima-satoshi
Copy link

@rgoers
Copy link
Member

rgoers commented May 10, 2022

There are 12 open PRs against taildir source. Before applying this I really need to know if this causes any of the other PRs to be moot. Or looking at it from the other perspective, if those PRs are applied what impact will they have on this one.

@iijima-satoshi
Copy link
Author

#297 is duplicated with this and is not sufficient to prevent this problem.
The reason is the following (my Jira comment).

I've met the same problem recently. This is because inode, filesize and lastModifiedTime are retrieved at different times.
To resolve this completely, it is necessary to retrieve these at the same time. I created a PR for this.

Therefore, if this PR is applied, #297 is unnecessary.

Other 11 PRs are derived from different problems and this PR would not affect the other PRs.

Additionally, I commented some PRs that I can understand.

@rgoers
Copy link
Member

rgoers commented Oct 8, 2022

Is it possible to create a test that fails without this change and succeeds when it is applied? How can I verify this fixes the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants