Patch for QueryParser to avoid throwing lots of exceptions that slows down the debugger #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
main control flow. When called very often, it slowed down a lot the execution time when the visual studio debugger was attached. This patch enhance the performance of the QueryParser under a debugger.
|
Thanks. We are not actively maintaining the 3.x branch as we put all our efforts in having a 4.x release soon. I'll be keeping this around for a reference. |
kentcb
added a commit
to kentcb/Xamarin-Lucene.Net
that referenced
this pull request
Nov 9, 2015
Applied apache/lucenenet#131. However, I note that exceptions are still thrown when searches are instigated (but not when the app first loads, which is at least something).
kentcb
added a commit
to kentcb/Xamarin-Lucene.Net
that referenced
this pull request
Nov 9, 2015
For some reason, @franckspike's patch (apache/lucenenet#131, applied in the previous commit) does not deal with all exceptions. Therefore, I've fleshed out the code so that no exceptions are thrown even during searches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch for QueryParser to avoid throwing lots of exceptions as part of main control flow.
When called very often, it slowed down a lot the
execution time when the visual studio debugger was attached.
This patch enhance the performance of the QueryParser under a debugger.