Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSITE-965] configure system requirements history #152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hboutemy
Copy link
Member

@hboutemy hboutemy commented May 6, 2023

No description provided.

@hboutemy hboutemy requested a review from michael-o May 6, 2023 21:48
<item name="site:jar" href="jar-mojo.html"/>
<item name="site:effective-site" href="effective-site-mojo.html"/>
<item name="site:help" href="help-mojo.html"/>
</item>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, while at it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we do this for other plugins is well? I am bit confused. It isn't wrong, but inconsistent with others, IMHO.

pom.xml Show resolved Hide resolved
@michael-o michael-o self-requested a review May 6, 2023 22:32
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, though I think that the changed site descriptor is now deviating from the others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants