Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test release-drafter #4129

Merged
merged 1 commit into from May 23, 2022
Merged

test release-drafter #4129

merged 1 commit into from May 23, 2022

Conversation

ebarboni
Copy link
Contributor

Hi, would like to see if it can help structuring release note.
I'm unaware if I can try it on my forks as labels belongs to apache/netbeans.
So this would be a first step

@ebarboni ebarboni added the CI Continuous Integration label May 19, 2022
@ebarboni ebarboni requested a review from mbien May 19, 2022 09:50
@mbien
Copy link
Member

mbien commented May 19, 2022

i don't know what i should review, I never used this :)

Is this a github bot which will create pull request for changelogs?

@ebarboni
Copy link
Contributor Author

Well it was more for technical I'm not sure copying the file is enough. It may help with a bit of configuration to get some info like
https://github.com/apache/archiva/releases

@mbien
Copy link
Member

mbien commented May 20, 2022

ah release-drafter its a github action. But it is also available as github "app" https://github.com/apps/release-drafter, however the app is deprecated and EOL ("The plan is to keep the GitHub App running for at least another year").

-> lets not use the app

Next we would have to figure out is if the action is part of the official github actions, if not, it will require extra steps. (git sub module deployment, see #4116 as example)

I would be also careful with github action access rights, I actually don't know how to configure this since apache projects have the rights set to minimum, see #4116 (comment) (I am stuck there)

In theory, this could be done via a github token, but I don't know how this works for apache projects, I don't have access to the project settings maybe someone else has or there is a different way how to solve this.

@mbien mbien added the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label May 20, 2022
@ebarboni
Copy link
Contributor Author

maybe I should have noticed this additionnal file

https://github.com/apache/archiva/blob/master/.github/workflows/release-drafter.yml

@mbien
Copy link
Member

mbien commented May 20, 2022

maybe I should have noticed this additionnal file

https://github.com/apache/archiva/blob/master/.github/workflows/release-drafter.yml

this is good info, because archiva is an apache project and it uses the action directly without any tricks. This means the action must be on the white list.

@ebarboni
Copy link
Contributor Author

updated with all files. this is not testable on pr I guess

@mbien
Copy link
Member

mbien commented May 20, 2022

if you push it to the master branch of your fork, you might be able to run it there, it should hopefully appear as workflow in your fork.

@ebarboni
Copy link
Contributor Author

labels are shared on forks ?

@mbien
Copy link
Member

mbien commented May 20, 2022

i don't know. but you should be able to run it and it should output something at least :) even without labels.

@ebarboni
Copy link
Contributor Author

tested a bit, it only generate the draft that you can edit to get the markdown and use at another place.
Will need nicer label configuration than the default but may help to get back release note on confluence

@ebarboni
Copy link
Contributor Author

image

I have limited access to the API so I guess it's acceptable but ajustement will be needed to fit our label.
This create a draf text that can be taken and stored.

@mbien mbien removed the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label May 23, 2022
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good!

@ebarboni
Copy link
Contributor Author

giving it a try

@ebarboni ebarboni merged commit 5d0fb43 into apache:master May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants