Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Gradle 4.10.2 #4111

Merged
merged 2 commits into from Nov 29, 2018
Merged

Update to Gradle 4.10.2 #4111

merged 2 commits into from Nov 29, 2018

Conversation

chetanmeh
Copy link
Member

@chetanmeh chetanmeh commented Nov 13, 2018

Updates to version 4.10.2 (from 4.8.1). This brings some improvement in maven publishing which would be useful for us in publishing our artifacts

See release notes here

Description

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@codecov-io
Copy link

codecov-io commented Nov 14, 2018

Codecov Report

Merging #4111 into master will decrease coverage by 4.88%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4111      +/-   ##
==========================================
- Coverage   86.16%   81.28%   -4.89%     
==========================================
  Files         151      151              
  Lines        7272     7272              
  Branches      468      468              
==========================================
- Hits         6266     5911     -355     
- Misses       1006     1361     +355
Impacted Files Coverage Δ
...core/database/cosmosdb/RxObservableImplicits.scala 0% <0%> (-100%) ⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala 0% <0%> (-95.54%) ⬇️
...sk/core/database/cosmosdb/CosmosDBViewMapper.scala 0% <0%> (-92.6%) ⬇️
...whisk/core/database/cosmosdb/CosmosDBSupport.scala 0% <0%> (-83.34%) ⬇️
...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala 0% <0%> (-62.5%) ⬇️
...in/scala/org/apache/openwhisk/common/Counter.scala 40% <0%> (-20%) ⬇️
...penwhisk/core/database/cosmosdb/CosmosDBUtil.scala 92% <0%> (-4%) ⬇️
...whisk/connector/kafka/KafkaConsumerConnector.scala 59.7% <0%> (-1.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a183b3e...d53a883. Read the comment docs.

Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chetanmeh
Copy link
Member Author

@vvraskin Can you trigger a PG run for this PR

@chetanmeh
Copy link
Member Author

@csantanapr Can you do a PG run for this?

@csantanapr
Copy link
Member

@chetanmeh Are all repos should be updated?
Or not necessary for now

@chetanmeh
Copy link
Member Author

No change required in other repos

@rabbah
Copy link
Member

rabbah commented Nov 23, 2018

@csantanapr is this good to merge? No issues for me locally.

@chetanmeh
Copy link
Member Author

chetanmeh commented Nov 28, 2018

@csantanapr mentioned that install task fails for test module with error

* What went wrong:
Execution failed for task ':tests:install'.
> Could not publish configuration 'archives'
   > Cannot publish artifact 'compileScala.mapping' (/Users/chetanm/git/apache/openwhisk/openwhisk/tests/build/tmp/scala/compilerAnalysis/compileScala.mapping) as it does not exist.

The build fails in install due to gradle/gradle#6849. There is a possible workaround

As a workaround, you can create a src/main/scala/ScalaForTestsWorkaround.scala with something like class ScalaForTestsWorkaround in it.

Now I see Gradle 5 also released on Nov 26. May be we switch to that as it shows good performance improvement (though referred bug still exist there)

@chetanmeh
Copy link
Member Author

@csantanapr Can you try again now a PG run with updated PR?

/**
* This class is a workaround for https://github.com/gradle/gradle/issues/6849
*/
class GradleWorkaround {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ 🤷‍♂️

@csantanapr
Copy link
Member

PG looks good

@csantanapr csantanapr merged commit a790bb8 into apache:master Nov 29, 2018
BillZong pushed a commit to BillZong/openwhisk that referenced this pull request Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants