New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Gradle 4.10.2 #4111
Update to Gradle 4.10.2 #4111
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4111 +/- ##
==========================================
- Coverage 86.16% 81.28% -4.89%
==========================================
Files 151 151
Lines 7272 7272
Branches 468 468
==========================================
- Hits 6266 5911 -355
- Misses 1006 1361 +355
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@vvraskin Can you trigger a PG run for this PR |
@csantanapr Can you do a PG run for this? |
@chetanmeh Are all repos should be updated? |
No change required in other repos |
@csantanapr is this good to merge? No issues for me locally. |
18a5fa4
to
e478978
Compare
@csantanapr mentioned that install task fails for test module with error
The build fails in install due to gradle/gradle#6849. There is a possible workaround
Now I see Gradle 5 also released on Nov 26. May be we switch to that as it shows good performance improvement (though referred bug still exist there) |
@csantanapr Can you try again now a PG run with updated PR? |
/** | ||
* This class is a workaround for https://github.com/gradle/gradle/issues/6849 | ||
*/ | ||
class GradleWorkaround {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦♂️ 🤷♂️
PG looks good |
Updates to version 4.10.2 (from 4.8.1). This brings some improvement in maven publishing which would be useful for us in publishing our artifacts
See release notes here
Description
Related issue and scope
My changes affect the following components
Types of changes
Checklist: