-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hoverfly-java to 0.18.1 #367
Conversation
f3431e5
to
c5899d3
Compare
c5899d3
to
ddfc741
Compare
ddfc741
to
65c7605
Compare
65c7605
to
0c4fc79
Compare
0c4fc79
to
059549a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI agrees
ff02855
to
659fadd
Compare
272a1c3
to
2f53bf8
Compare
CI failed, google-cloud |
2f53bf8
to
babca3a
Compare
649ec5c
to
16b39bb
Compare
948e982
to
eb9bc47
Compare
051b2be
to
d340958
Compare
d340958
to
9282321
Compare
indeed curious that Google components seem to be consistently failing with TLS errors after this update. Something to investigate. |
46dcbcd
to
6ba6844
Compare
55dd0b6
to
5640c5f
Compare
5640c5f
to
6c389e4
Compare
6c389e4
to
fc38d99
Compare
fc38d99
to
51bc0e5
Compare
10474ce
to
118c8df
Compare
directly using hoverfly-java cert will cause: and then I customize the certificate it will complain but has a different message: |
10d7c9b
to
db12d8f
Compare
db12d8f
to
487dd50
Compare
Finally, I found the problem because hoverfly-java was updated their certificate in the jar. I found this problem through a custom certificate, and then verified it was valid by updating the certificate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work!
I guess this might impact users who are also still on the old certificates, but that might actually be an improvement
There are still two certificates that have not been updated, my last commit updated it. The CI will be passed. @raboof can you review this? thanks. |
About this PR
π¦ Updates io.specto:hoverfly-java from
0.14.1
to0.14.4
π GitHub Release Notes - Version Diff
Usage
β Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conf
file.Have a fantastic day writing Scala!
β Adjust future updates
Add this to your
.scala-steward.conf
file to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: