Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hoverfly-java to 0.18.1 #367

Merged
merged 4 commits into from
Jun 9, 2024
Merged

Update hoverfly-java to 0.18.1 #367

merged 4 commits into from
Jun 9, 2024

Conversation

scala-steward-asf[bot]
Copy link
Contributor

@scala-steward-asf scala-steward-asf bot commented Jan 27, 2024

About this PR

πŸ“¦ Updates io.specto:hoverfly-java from 0.14.1 to 0.14.4

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "io.specto", artifactId = "hoverfly-java" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "io.specto", artifactId = "hoverfly-java" }
}]
labels: test-library-update, early-semver-minor, semver-spec-patch, commit-count:1

@scala-steward-asf scala-steward-asf bot force-pushed the update/hoverfly-java-0.14.4 branch 3 times, most recently from f3431e5 to c5899d3 Compare February 4, 2024 02:17
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI agrees

@scala-steward-asf scala-steward-asf bot force-pushed the update/hoverfly-java-0.14.4 branch 3 times, most recently from ff02855 to 659fadd Compare March 3, 2024 02:15
@scala-steward-asf scala-steward-asf bot force-pushed the update/hoverfly-java-0.14.4 branch 2 times, most recently from 272a1c3 to 2f53bf8 Compare March 13, 2024 05:51
@laglangyue
Copy link
Contributor

CI failed, google-cloud

@scala-steward-asf scala-steward-asf bot force-pushed the update/hoverfly-java-0.14.4 branch 2 times, most recently from 649ec5c to 16b39bb Compare March 31, 2024 02:15
@scala-steward-asf scala-steward-asf bot force-pushed the update/hoverfly-java-0.14.4 branch 2 times, most recently from 948e982 to eb9bc47 Compare April 11, 2024 22:35
@scala-steward-asf scala-steward-asf bot force-pushed the update/hoverfly-java-0.14.4 branch 3 times, most recently from 051b2be to d340958 Compare April 21, 2024 02:18
@raboof raboof force-pushed the update/hoverfly-java-0.14.4 branch from d340958 to 9282321 Compare April 25, 2024 10:08
@raboof
Copy link
Member

raboof commented Apr 25, 2024

indeed curious that Google components seem to be consistently failing with TLS errors after this update. Something to investigate.

@scala-steward-asf scala-steward-asf bot force-pushed the update/hoverfly-java-0.14.4 branch 2 times, most recently from 46dcbcd to 6ba6844 Compare May 5, 2024 02:17
@scala-steward-asf scala-steward-asf bot force-pushed the update/hoverfly-java-0.14.4 branch 2 times, most recently from 55dd0b6 to 5640c5f Compare May 19, 2024 02:19
@Roiocam Roiocam force-pushed the update/hoverfly-java-0.14.4 branch 3 times, most recently from 10474ce to 118c8df Compare June 9, 2024 06:29
@Roiocam
Copy link
Member

Roiocam commented Jun 9, 2024

directly using hoverfly-java cert will cause: java.security.cert.CertPathValidatorException: signature check failed

and then I customize the certificate it will complain but has a different message: Cause: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target

@Roiocam Roiocam force-pushed the update/hoverfly-java-0.14.4 branch from 10d7c9b to db12d8f Compare June 9, 2024 13:46
@Roiocam Roiocam force-pushed the update/hoverfly-java-0.14.4 branch from db12d8f to 487dd50 Compare June 9, 2024 13:50
@Roiocam
Copy link
Member

Roiocam commented Jun 9, 2024

Finally, I found the problem because hoverfly-java was updated their certificate in the jar.

I found this problem through a custom certificate, and then verified it was valid by updating the certificate.

@Roiocam Roiocam requested a review from raboof June 9, 2024 13:57
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

I guess this might impact users who are also still on the old certificates, but that might actually be an improvement

@Roiocam
Copy link
Member

Roiocam commented Jun 9, 2024

There are still two certificates that have not been updated, my last commit updated it. The CI will be passed.

@raboof can you review this? thanks.

@Roiocam Roiocam requested review from He-Pin and pjfanning June 9, 2024 13:59
@Roiocam Roiocam changed the title Update hoverfly-java to 0.14.4 Update hoverfly-java to 0.18.1 Jun 9, 2024
@raboof raboof merged commit d42135c into main Jun 9, 2024
51 checks passed
@Roiocam Roiocam deleted the update/hoverfly-java-0.14.4 branch June 9, 2024 17:56
@pjfanning pjfanning added this to the 1.1.0-M1 milestone Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants