Improve implement for pekko-connectors-text #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roiocam
reviewed
Apr 29, 2024
| .Flow[ByteString] | ||
| .via(new CharsetDecodingFlow(incoming)) | ||
| .asJava | ||
| pekko.stream.javadsl.Flow.fromGraph(new CharsetDecodingFlow(incoming)) |
There was a problem hiding this comment.
pekko.stream.javadsl.Flow.fromGraph will be use the same scaladsl in the end, this change may break the consistency of code style, you may want to use pekko.stream.scaladsl.Flow.fromGraph(....).asJava
There was a problem hiding this comment.
update by using scaladsl.TextFlow
| @@ -44,7 +43,6 @@ object TextFlow { | |||
| * Translates a stream of bytes from one character encoding into another. | |||
| */ | |||
| def transcoding(incoming: Charset, outgoing: Charset): Flow[ByteString, ByteString, NotUsed] = | |||
| Flow[ByteString] | |||
| .via(new CharsetTranscodingFlow(incoming, outgoing)) | |||
| Flow.fromGraph(new CharsetTranscodingFlow(incoming, outgoing)) | |||
There was a problem hiding this comment.
Would you like to take a look? which better?
He-Pin
reviewed
Apr 29, 2024
| @@ -14,7 +14,6 @@ | |||
| package org.apache.pekko.stream.connectors.text.impl | |||
|
|
|||
| import java.nio.charset.Charset | |||
|
|
|||
| pekko.stream.scaladsl | ||
| .Flow[ByteString] | ||
| .via(new CharsetTranscodingFlow(incoming, outgoing)) | ||
| .asJava |
There was a problem hiding this comment.
I have to say, they are same code after all
There was a problem hiding this comment.
thanks, I update it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More direct and simple implementation