s3: avoid array copies when dealing with ByteStrings #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mdedetrich You are the most active contributor to the S3 code base. Do these changes look ok to you? |
pjfanning
commented
May 16, 2024
| @@ -36,7 +36,16 @@ package object auth { | |||
| new String(out) | |||
| } | |||
|
|
|||
| @InternalApi private[impl] def encodeHex(bytes: ByteString): String = encodeHex(bytes.toArray) | |||
| @InternalApi private[impl] def encodeHex(bytes: ByteString): String = { | |||
| val length = bytes.length | |||
There was a problem hiding this comment.
ByteString implements IndexedSeq[Byte] so we can iterate it without converting it to an array.
There was a problem hiding this comment.
looking at the ByteStrings code (complex ByteString made up of underlying ByteStrings) the apply(Int) function and the iterator function are not performant.
So I'm now thinking of changing this to
def encodeHex(bytes: ByteString): String = encodeHex(bytes.toArrayUnsafe)
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the 'unsafe' methods are ok if you know the data is not being mutated