Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add link validator CI job #204

Merged
merged 2 commits into from
Jul 17, 2023
Merged

add link validator CI job #204

merged 2 commits into from
Jul 17, 2023

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Jun 27, 2023 •
edited

  • we have similar CI jobs in other repos

@pjfanning pjfanning marked this pull request as draft June 27, 2023 09:24
@pjfanning
Copy link
Contributor Author

currently broken - https://github.com/apache/incubator-pekko-http/actions/runs/5388318117/jobs/9780805476

@pjfanning
Copy link
Contributor Author

with #204 - we're getting to the point where these broken Java API links are the main remaining issue

@mdedetrich
Copy link
Contributor

@pjfanning Can you confirm that link validator works when #231 is merged?

@mdedetrich
Copy link
Contributor

Hmm problem is still there, let me look into it

@mdedetrich mdedetrich mentioned this pull request Jul 17, 2023
Merged
@mdedetrich
Copy link
Contributor

For the AbstractFunction1 issue, it needs to be manually ignored (see https://github.com/apache/incubator-pekko/blob/34a3fa704c3ec4cbabe1956bf3ffc769ba6fc5ba/scripts/link-validator.conf#L59)

@pjfanning
add link validator CI job
9e5cd53 
Update build.sbt

Update link-validator.conf

try to fix doc version

Update build.sbt

rework

Update link-validator.conf

Update build.sbt

Update link-validator.conf

Update build.sbt

Update link-validator.conf

Update link-validator.conf

Update link-validator.yml
@pjfanning pjfanning marked this pull request as ready for review July 17, 2023 12:55
mdedetrich
mdedetrich approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning merged commit 8ee9ed3 into apache:main Jul 17, 2023
14 checks passed
@pjfanning pjfanning deleted the link-validator-job branch July 17, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdedetrich mdedetrich mdedetrich approved these changes

@jrudolph jrudolph Awaiting requested review from jrudolph

@gmethvin gmethvin Awaiting requested review from gmethvin

@He-Pin He-Pin Awaiting requested review from He-Pin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pjfanning @mdedetrich