Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fetch tags from latest checkout action #88

Merged
merged 1 commit into from Sep 6, 2023

Conversation

mdedetrich
Copy link
Contributor

The latest version of the checkout github actions now supports a fetch-tags flag which does as described, i.e. it will fetch all of our tags which removes the various workarounds that was used before (i.e. manually running git fetch command) etc etc, see actions/checkout#579

This will also help in the erroneous errors that we get in CI, i.e.

[error] Failed to derive version from git tags. Maybe run `git fetch --unshallow` or `git fetch upstream` on a fresh git clone from a fork? Derived version: 0.0.0+1-337943bd-SNAPSHOT`

with:
# See https://github.com/actions/checkout/issues/299#issuecomment-677674415
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mdedetrich mdedetrich merged commit 8db6f69 into apache:main Sep 6, 2023
18 checks passed
@mdedetrich mdedetrich deleted the fetch-tags-when-checking-out branch September 6, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants