Update javafmt

[mdedetrich]

Updates and applies javafmt

[mdedetrich]

@He-Pin There seems to be some regression in the new version of javafmt, if you look at https://github.com/apache/incubator-pekko/actions/runs/5997908862/job/16265219790?pr=593 its failing to compile some java sources

[He-Pin]

I tried it locally with sbt Test/compile:

[info] done compiling
[success] Total time: 591 s (09:51), completed 2023-8-28 17:48:46

[mdedetrich]

I tried it locally with sbt Test/compile:

[info] done compiling
[success] Total time: 591 s (09:51), completed 2023-8-28 17:48:46

If you run validateCompile in sbt this is where you get the problem

[mdedetrich]

So I looked at diff for one of the problematic sources, i.e. actor-typed-tests/src/test/java/jdocs/org/apache/pekko/typed/AggregatorTest.java and all that javafmt did was re-sort the imports so I have no idea why this is failing to compile, it seems to be a multi-jvm thing?

[He-Pin]

I will take a try after work, wared.

[mdedetrich]

So I did a little digging, the core issue appear to be that the Java sources are not fed properly into the compiler i.e.

[error] /Users/mdedetrich/github/incubator-pekko/actor-typed-tests/src/test/java/jdocs/org/apache/pekko/typed/AggregatorTest.java:136:1: cannot find symbol
[error]   symbol:   class AbstractBehavior
[error]   location: interface jdocs.org.apache.pekko.typed.AggregatorTest.IllustrateUsage
[error] AbstractBehavior

Now AbstractBehavior is defined as a Scala source in another project. Initially I thought that the problem might be with compile order so I tried to set MultiJvm / compileOrder := CompileOrder.Mixed/MultiJvm / compileOrder := CompileOrder.ScalaThenJava into MultiJvm settings but that didn't have any impact.

Now if I revert some of the changes that javafmt did on some of the source files, it does genuinely fix the issue. It appears that the import order is changing the semantics of the java source files.

[mdedetrich]

https://stackoverflow.com/questions/50145575/why-does-rearranging-imports-cause-compilation-to-fail might be related, in which case we should change the formatting style or add these files into ignore