POC +str Add StreamCollector api for unsafe transformation. #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
reviewed
Sep 4, 2023
stream/src/main/scala/org/apache/pekko/stream/scaladsl/Flow.scala
Outdated
Show resolved
Hide resolved
|
Also pinging @jrudolph because he did prior work on this |
He-Pin
force-pushed
the
flowEmiter
branch
4 times, most recently
from
5970749
to
d245d4d
Compare
He-Pin
changed the title
He-Pin
commented
Sep 10, 2023
| case Some(elem) => handleSync(elem) | ||
| case None => future.onComplete(handle(_))(pekko.dispatch.ExecutionContexts.parasitic) | ||
| } | ||
| } |
|
Now JDK22 ships a Gather https://openjdk.org/jeps/461 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Make it simpler when integrating with other effect system.
When reading : https://alexn.org/blog/2023/04/17/integrating-akka-with-cats-effect-3/ ; I think there should be a simpler api to integrate other effect system ,which does not need to transform back to
Future.The
unsafeTransformcan be implemented in similar way.refs: typelevel/cats-effect#3807
Related work: akka/akka#28674 from @jrudolph
And the
unsafeTransformcan be implemented in similar wayNotes:
unsafestatements, it's unsafe.F[_]typeclass implementation.@alexandru ping