Adding gRPC samples to docs. #696
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samueleresca Is this ready to be reviewed? |
The PR is ready but it depends on: apache/pekko-samples#78 |
laglangyue
reviewed
Dec 18, 2023
| @@ -272,6 +272,8 @@ Some of the challenges that HTTP tackles: | |||
|
|
|||
| This library provides an implementation of gRPC that integrates nicely with the @ref:[HTTP](#http) and @ref:[Streams](#streams) modules. It is capable of generating both client and server-side artifacts from protobuf service definitions, which can then be exposed using Pekko HTTP, and handled using Streams. | |||
|
|
|||
| A sample using the gRPC module can be found at: @extref[gRPC on Kubernetes example project](samples:pekko-sample-grpc-kubernetes-scala) | |||
There was a problem hiding this comment.
It doesn't seem necessary to add it here to maintain a consistent style，and links to samples in example already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pekko-grpc-sample-kubernetes-scala links in the doc.
Related to apache/pekko-grpc#58
Depends on: apache/pekko-samples#78