[Tests] Adapt FastThreadLocalStateCleaner to Netty changes: suppress excessive logging in tests #15269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…excessive logging
- suppresses this warning log entry:
java.lang.RuntimeException: It's not thread-safe to get 'threadLocalMap' which doesn't belong to the caller thread
at io.netty.util.concurrent.FastThreadLocalThread.threadLocalMap(FastThreadLocalThread.java:80) ~[netty-common-4.1.76.Final.jar:4.1.76.Final]
lhotari
added
type/enhancement
lhotari
changed the title
nicoloboschi
approved these changes
Apr 22, 2022
eolivelli
approved these changes
Apr 22, 2022
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
FastThreadLocalStateCleaner is used in apache/pulsar tests to clean up state stored in thread local fields using Netty's FastThreadLocal. This solution was added in #10195 to reduce test flakiness caused by state carried on from one test to another.
This change included in 4.1.75.Final added the logging when the thread local state is accessed from another thread. This logging clutters the test run logs and therefore it should be eliminated.
Pulsar was upgraded to Netty 4.1.76.Final in #15212.
Modifications