Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][sql] Fix jline version to 3.21.0 #18207

Merged
merged 2 commits into from Oct 27, 2022

Conversation

tisonkun
Copy link
Member

@tisonkun tisonkun commented Oct 26, 2022

Using jline before 3.21.0 may cause a "Bad address" failure on Apple M1 environment. We're using 3.21.0 globally, so forcibly apply this version to pulsar-sql dependencies.

See also scala/scala#9807.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Copy link
Member Author

cc @merlimat @nicoloboschi

Copy link
Contributor

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please update the pull description

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 26, 2022
@tisonkun
Copy link
Member Author

@nicoloboschi Thanks for your review. Updated.

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

Merging #18207 (1ad6953) into master (6c65ca0) will increase coverage by 15.90%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #18207       +/-   ##
=============================================
+ Coverage     34.91%   50.82%   +15.90%     
- Complexity     5707     8724     +3017     
=============================================
  Files           607      612        +5     
  Lines         53396    53579      +183     
  Branches       5712     5742       +30     
=============================================
+ Hits          18644    27229     +8585     
+ Misses        32119    23345     -8774     
- Partials       2633     3005      +372     
Flag Coverage Δ
unittests 50.82% <0.00%> (+15.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...in/java/org/apache/pulsar/PulsarBrokerStarter.java 0.00% <ø> (ø)
.../org/apache/pulsar/PulsarClusterMetadataSetup.java 0.00% <ø> (ø)
...g/apache/pulsar/PulsarClusterMetadataTeardown.java 0.00% <ø> (ø)
...org/apache/pulsar/PulsarInitialNamespaceSetup.java 0.00% <ø> (ø)
.../main/java/org/apache/pulsar/PulsarStandalone.java 0.00% <0.00%> (ø)
...ava/org/apache/pulsar/PulsarStandaloneBuilder.java 0.00% <ø> (ø)
...ava/org/apache/pulsar/PulsarStandaloneStarter.java 0.00% <ø> (ø)
...apache/pulsar/broker/service/TopicListService.java 10.65% <0.00%> (-44.27%) ⬇️
...g/apache/pulsar/broker/service/StreamingStats.java 75.67% <0.00%> (-8.11%) ⬇️
...tent/NonPersistentDispatcherMultipleConsumers.java 40.74% <0.00%> (-7.41%) ⬇️
... and 198 more

@tisonkun
Copy link
Member Author

/pulsarbot run-failure-checks

@tisonkun
Copy link
Member Author

/pulsarbot run-failure-checks

@tisonkun
Copy link
Member Author

ping @merlimat @nicoloboschi

I think this patch is ready for merge now. Tests fail on:

  Error:  testSharedSamePriorityConsumer(org.apache.pulsar.broker.service.persistent.SimpleProducerConsumerTestStreamingDispatcherTest)  Time elapsed: 16.774 s  <<< FAILURE!
  java.lang.AssertionError: expected [500] but found [501]
  	at org.testng.Assert.fail(Assert.java:99)
  	at org.testng.Assert.failNotEquals(Assert.java:1037)
  	at org.testng.Assert.assertEqualsImpl(Assert.java:140)
  	at org.testng.Assert.assertEquals(Assert.java:122)
  	at org.testng.Assert.assertEquals(Assert.java:907)
  	at org.testng.Assert.assertEquals(Assert.java:917)
  	at org.apache.pulsar.client.api.SimpleProducerConsumerTest.testSharedSamePriorityConsumer(SimpleProducerConsumerTest.java:2513)

which is reported at #16795

@codelipenghui codelipenghui added this to the 2.12.0 milestone Oct 27, 2022
@codelipenghui codelipenghui added type/bug The PR fixed a bug or issue reported a bug area/sql Pulsar SQL related features labels Oct 27, 2022
@codelipenghui codelipenghui merged commit 6657fe4 into apache:master Oct 27, 2022
@tisonkun tisonkun deleted the fix-pulsar-sql-jline branch October 27, 2022 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sql Pulsar SQL related features doc-not-needed Your PR changes do not impact docs type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants