New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][sql] Fix jline version to 3.21.0 #18207
Conversation
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please update the pull description
@nicoloboschi Thanks for your review. Updated. |
Codecov Report
@@ Coverage Diff @@
## master #18207 +/- ##
=============================================
+ Coverage 34.91% 50.82% +15.90%
- Complexity 5707 8724 +3017
=============================================
Files 607 612 +5
Lines 53396 53579 +183
Branches 5712 5742 +30
=============================================
+ Hits 18644 27229 +8585
+ Misses 32119 23345 -8774
- Partials 2633 3005 +372
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
ping @merlimat @nicoloboschi I think this patch is ready for merge now. Tests fail on:
which is reported at #16795 |
Using jline before 3.21.0 may cause a "Bad address" failure on Apple M1 environment. We're using 3.21.0 globally, so forcibly apply this version to pulsar-sql dependencies.
See also scala/scala#9807.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: